Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp7145585rwl; Mon, 9 Jan 2023 18:57:31 -0800 (PST) X-Google-Smtp-Source: AMrXdXsiKnvRJVzSsHW/KhvUaQxsqMa5RGVCWM+rRZ6idLHgeNdc20oOfSS/cbY7Z5XfFiJnq2OJ X-Received: by 2002:aa7:c1d5:0:b0:489:64aa:d1aa with SMTP id d21-20020aa7c1d5000000b0048964aad1aamr43396318edp.16.1673319451680; Mon, 09 Jan 2023 18:57:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673319451; cv=none; d=google.com; s=arc-20160816; b=Rl3AGjrA4+RWaLV5rWSoYI6GnvenznjsxwuZQhImwTUHobRNX8YXZLbzs8RAQbtAAQ rSNRHnO4dH7QGwBiR2Ggm2y58rGyiy2vTwczAhCE/IKfW2JigwD/RPCdIQSmV79r8zuB iaeH2zx4uygCSTwYoz+I0+C3LK42oysNoBeR6bJsTacrqFizsolXlHej2FWs3DPm8qlz t/9ITM8AgrJdTStNjYCy+CkRepwxnY++kPNhJdb5gdYNmub/BalkCW40kyqE/t36njhm pxBrIqD8FAMMyfjNT1r8iUnQEYdecHVi2ZbOwjiZHT9MBVZYIiFiFrNZvCd1/15BzEJm vmSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=JMNXsPxYhVKORIJezaHqnFFRc7qB+CERUFEvx8HBmPI=; b=cjM8qUO3MW9Z6Ozzo06wEM/ca84NjTXoUYU0NuIOdF4dT6vyUW5MmuIEI3M6/6xRmY W6lDFUuySa+bFDI6LwqBGhuC5oabOkcx/b21Bm2gCxe0TvVypx4rIgKddrIsUtpFeYYc yVqMAXrWyg7z7p7GQLXs8QGyoCo0CT3uv/Kt6qNJBq326xnOhoK5NRVhf+UdwTH4jzmD QaphQq1LlyU9EPuVArpbPXCx6nO1dZwXujNL69+x/zfVoyjSjjAnYuekWtegKa/vXf+y xbYvAXZlwke6yJSnL1x8x2K3DgpC5sFPHherZujmVodfPSf7amojL6L0D82XOfiY+Ws3 N8AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=cEgGQa5z; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g1-20020a056402320100b00483a5850a5fsi9837781eda.373.2023.01.09.18.57.02; Mon, 09 Jan 2023 18:57:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=cEgGQa5z; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229638AbjAJCiE (ORCPT + 99 others); Mon, 9 Jan 2023 21:38:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32838 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229560AbjAJCiD (ORCPT ); Mon, 9 Jan 2023 21:38:03 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 424F7B7F0; Mon, 9 Jan 2023 18:38:02 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CFEE8614BB; Tue, 10 Jan 2023 02:38:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A862CC433EF; Tue, 10 Jan 2023 02:38:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1673318281; bh=Y64MR4JK48Pzp25aGh8zQ5wqMuidq5kQnWPvb8e5i9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=cEgGQa5zyUoGHgJLglyternN0KDprFlgUCd6BKIvxiD2upcGonWYYLG4H/yh6Ywbg mhfo1DGbQOmqUd8qvuzP76ikYLMkESZ1gih+2voSna2iJrFiRvv6jIDGac5HZ6dRo/ 9yjcHwGTRnn5HHiw2V0ZuL50gw2Z3KriC6g3L4ro= Date: Mon, 9 Jan 2023 18:37:59 -0800 From: Andrew Morton To: Eric Biggers Cc: linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, linux-xfs@vger.kernel.org, Andrey Albershteyn Subject: Re: [PATCH v2 10/11] fs/buffer.c: support fsverity in block_read_full_folio() Message-Id: <20230109183759.c1e469f5f2181e9988f10131@linux-foundation.org> In-Reply-To: <20221223203638.41293-11-ebiggers@kernel.org> References: <20221223203638.41293-1-ebiggers@kernel.org> <20221223203638.41293-11-ebiggers@kernel.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, 23 Dec 2022 12:36:37 -0800 Eric Biggers wrote: > After each filesystem block (as represented by a buffer_head) has been > read from disk by block_read_full_folio(), verify it if needed. The > verification is done on the fsverity_read_workqueue. Also allow reads > of verity metadata past i_size, as required by ext4. Sigh. Do we reeeeealy need to mess with buffer.c in this fashion? Did any other subsystems feel a need to do this? > This is needed to support fsverity on ext4 filesystems where the > filesystem block size is less than the page size. Does any real person actually do this?