Received: by 2002:a05:6358:16cc:b0:ea:6187:17c9 with SMTP id r12csp8259569rwl; Tue, 10 Jan 2023 11:00:15 -0800 (PST) X-Google-Smtp-Source: AMrXdXvfjXHf3EdYHQO7AD/sL3SJrSacO9tlym/YajlebjNTefh37mAvgayWdmJ+K1U1MHDLpLjc X-Received: by 2002:a05:6402:5245:b0:499:bcd7:a968 with SMTP id t5-20020a056402524500b00499bcd7a968mr7069367edd.22.1673377215532; Tue, 10 Jan 2023 11:00:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673377215; cv=none; d=google.com; s=arc-20160816; b=uMSpPgA1zOYpfnsleDYGedH54SkWxqkJDSr8N4aAWPcmsg6naFqklgquPv8tBr4SdH iy9L/W1Y5zR3X5zx+GdwIBlZw07wUMXPzBS5c9U3zJ7Xql/V+1PyNpOjQdCQ3YH71fi4 A3w9NWIYD0+RtSFAbFlqws9dTaE+saXaMUfbvSw/lhprR6oh+Op5GJjsCUwa7ucu6FH5 avESNrTHyM35EYLUSOVovQ/WnJNycSyJe6pVYJ9Iq3Ls4IjvGJvUesSWFY/28U3xA8vu b7hJN37yQDtzvTf7IypO+66tY1bvjql/+vYc0Mun+r66kT43Vgc/7lz12uU2MRvMplAn c5fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=c6EPXskDxnwTd/ZxTB5zCoUz0mDk5kc73CPozFZqE24=; b=V1gntM99ExFISxUh0tYdn5TOoVflp4rF3VbBkVfLpJ2Hz8a1XGiVz+xsVMF8jAsmSy Vqb0ZvZj880JDGs+i64q2Ie5Mkgw//tU7OlEfFJ3HU/CoMm9WsZ/c9SKCAPlWsTExbu7 Bfqa9mpVNTqoGCgtqrk5iRoHK3CrWbZVVU1uHyeqMqz+/cbAl6eO+COPqQS0YV8+caVP CX/VWLQMmEB1kwuw+IDIxK/AaHx/UqQ5aPI6E3qMBcMbLc+N5qVS0lX+B+bLrbniqZ4q jdi21xf3efHoCBpujtaEIseeHtc0cd5DVB7XZTLf5h3Spi3BU9YfTkpsGhpufwSHji73 ycFw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dqTUBuLo; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z11-20020a056402274b00b00482071c30e3si15751845edd.39.2023.01.10.10.59.45; Tue, 10 Jan 2023 11:00:15 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=dqTUBuLo; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239563AbjAJStJ (ORCPT + 99 others); Tue, 10 Jan 2023 13:49:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33100 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239727AbjAJSsg (ORCPT ); Tue, 10 Jan 2023 13:48:36 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E37265372; Tue, 10 Jan 2023 10:42:05 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 3A7B861881; Tue, 10 Jan 2023 18:42:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 767D3C433EF; Tue, 10 Jan 2023 18:42:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673376124; bh=g3CRnTTazWLR2Hh58q3CRcJBbpAnJEnxst035yVP2JI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dqTUBuLoJqiA6XVnVZWR+jPO7aNl7WWPgJZJ6OhsJDk+nWTQLSw1HLn617q1B+IvI /xTo4MhG+C4e92CmQbPuosfUhQ67lQURj0w8zUxeHdq7wEtl/3bEBJvRhFoDbkGOJ1 juAKdMMT2/e5U2s2Z4atHu89Hss1utQctXg5R6xhmnBzEolqYZJ9/xL0FFyEEibHXq UrgmBT/fs/d6aBCiXmHVshq2kcdGkQVLUY96mAQK+qSTH9FU9V5Rlj1t5sZsxs0BL9 6Ggt3vRGC2qhEGPvw1rY/K8TD+43AXWwGLnhL4RQCfiKKgQkmW4pbmHcc4PYZM3eaa whUGhcZMEyfNA== Date: Tue, 10 Jan 2023 18:42:03 +0000 From: Eric Biggers To: Alexander Potapenko Cc: dsterba@suse.cz, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, tytso@mit.edu, adilger.kernel@dilger.ca, jaegeuk@kernel.org, chao@kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [PATCH 2/5] fs: affs: initialize fsdata in affs_truncate() Message-ID: References: <20221121112134.407362-1-glider@google.com> <20221121112134.407362-2-glider@google.com> <20221122145615.GE5824@twin.jikos.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Jan 10, 2023 at 01:27:03PM +0100, Alexander Potapenko wrote: > On Tue, Nov 22, 2022 at 3:56 PM David Sterba wrote: > > > > On Mon, Nov 21, 2022 at 12:21:31PM +0100, Alexander Potapenko wrote: > > > When aops->write_begin() does not initialize fsdata, KMSAN may report > > > an error passing the latter to aops->write_end(). > > > > > > Fix this by unconditionally initializing fsdata. > > > > > > Suggested-by: Eric Biggers > > > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > > > Signed-off-by: Alexander Potapenko > > > > With the fixed Fixes: reference, > > > > Acked-by: David Sterba > > Hi David, > > I've noticed that the ext4 counterpart of this patch is in the > upstream tree already, whereas the affs, f2fs, hfs and hfsplus > versions are not. > Are they picked via a different tree? Generally each filesystem has its own development tree. All the information is in MAINTAINERS. hfs and hfsplus are unmaintained, though. Maybe try asking Andrew Morton to apply the hfs and hfsplus patches, and any others that don't get applied, as "maintainer of last resort". - Eric