Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp205610rwb; Thu, 12 Jan 2023 18:29:24 -0800 (PST) X-Google-Smtp-Source: AMrXdXvpk1zaL+AmrwD7IvnFFmRrtVloExjbQhE2Quhui0Dglu9A7lfpPwW4JXkEEUv3yhngoDxI X-Received: by 2002:a62:8412:0:b0:587:df0a:804d with SMTP id k18-20020a628412000000b00587df0a804dmr18440090pfd.27.1673576963725; Thu, 12 Jan 2023 18:29:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673576963; cv=none; d=google.com; s=arc-20160816; b=x+fzESTd/h9SgLoyfCaUdcpbE8OACB3l8fY5tGiuQncE2vvKvNKt73BcoAins9TiTl /DfFsndBDG1Bny+QYskkZ2xthx0Cd4X3kYsocMl7J1uZsqQyF6RpW7BEQS0CP9lNlvdX 44Gkc6GJXzlqrGy6eq0U3LAivp5yBkIpfjtbWaZ3U60Fw5AgJ+yUq8QWxTeum5fQKUtO gldwIJeWzRW8ylG5QJGZ2s1p/vtxM4NCLG76bcwU4+TfcANJEz/CbbaG9v8+Phcg+9j1 00vHsfwP2QThIwzHu1nLexRU/Eu4Oj/svbYUwcWZEYE6Cn39clfTLpNu359L/Ww3U15T 2axA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=tHPdY5AQT1VbIobmvq2ya4gksHeG7GOHtqPamHi95m4=; b=aFCZ6vByXme1tKW2gkGpBU4w+ljxW5SS7/lF3d3qPtiR4OcNuZF0jQROoA6kVEz78H H8Nfn5Db5UqLHCjTc5WgdShURtktaf4dLz8PvN8pJ7kOGFiWHDyomo4ulbVBnkm2pZf0 BGeJzyqPj/htFyoLkwvXACpVOPA4AmAKI2YJYWA4CzfWMLFD1WSwNSz3Rl5tmCsrGcuZ XwGKN+KmaKHdVkmG7NkOJp+29oH5rdjClYKXqmpTRCuYAYSZBdFchAjfVUImXbTSLWpq g3CA9th37a3/0AaWO24/jfH9fi5sNiaZfXyEE9c0xW89cD+F1a59DrnkuTKHRle1F+f/ O/HA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YWlQxI+h; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id g136-20020a62528e000000b005383ec972b3si18444591pfb.72.2023.01.12.18.28.51; Thu, 12 Jan 2023 18:29:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YWlQxI+h; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234573AbjAMC0K (ORCPT + 99 others); Thu, 12 Jan 2023 21:26:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232777AbjAMC0J (ORCPT ); Thu, 12 Jan 2023 21:26:09 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F0C40A469; Thu, 12 Jan 2023 18:26:08 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 95D7DB8201F; Fri, 13 Jan 2023 02:26:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BC02FC433D2; Fri, 13 Jan 2023 02:26:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1673576766; bh=IP2gv1lTVyvsOnZCZLK4oCIKQqjrH8jP6S6HKbMvK+M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YWlQxI+haamKaSA4y73abmE68G+07SlfaDFORGIyKKcfmyMJNq9qC2UyKF08c8jv5 eMYw/7Rd98qwIxFP+qECBAQTmuID8FLkLc5Jl9iro9eB8RtgVRjT5hkyJ32f4zzyDf 1dZjlArfXlIbS2OFbAg1JbfFzvSelHFBIsYrKm06IdRGk7qHKs6jmrTkxkuymPobVt HA8S997AtuHFQMuOX2+WRQatC+4hYmGw0i0AAbM4gc9dmNWokA4otw6HPh6n3FSPHs x/viqyVHsuxDL6ckuJwh9xv3w0DjJcikxRF5SnujxI7dshe4uqXhqug+yb4dJB0YDF rXlCP+dazW2kA== Date: Thu, 12 Jan 2023 18:26:04 -0800 From: Eric Biggers To: Jens Axboe Cc: Pavel Begunkov , io-uring@vger.kernel.org, syzbot , adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, nathan@kernel.org, ndesaulniers@google.com, syzkaller-bugs@googlegroups.com, trix@redhat.com, tytso@mit.edu, viro@zeniv.linux.org.uk Subject: Re: [io_uring] KASAN: use-after-free Read in signalfd_cleanup Message-ID: References: <000000000000f4b96605f20e5e2f@google.com> <000000000000651be505f218ce8b@google.com> <9d8339cf-5b66-959a-254d-839c0de92ec8@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <9d8339cf-5b66-959a-254d-839c0de92ec8@kernel.dk> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, Jan 12, 2023 at 07:17:25PM -0700, Jens Axboe wrote: > On 1/12/23 7:12 PM, Eric Biggers wrote: > > Over to the io_uring maintainers and list, based on the reproducer...: > > > > r0 = signalfd4(0xffffffffffffffff, &(0x7f00000000c0), 0x8, 0x0) > > r1 = syz_io_uring_setup(0x87, &(0x7f0000000180), &(0x7f0000ffc000/0x3000)=nil, &(0x7f00006d4000/0x1000)=nil, &(0x7f0000000000)=0x0, &(0x7f0000000040)=0x0) > > pipe(&(0x7f0000000080)={0xffffffffffffffff, 0xffffffffffffffff}) > > write$binfmt_misc(r4, &(0x7f0000000000)=ANY=[], 0xfffffecc) > > syz_io_uring_submit(r2, r3, &(0x7f0000002240)=@IORING_OP_POLL_ADD={0x6, 0x0, 0x0, @fd=r0}, 0x0) > > io_uring_enter(r1, 0x450c, 0x0, 0x0, 0x0, 0x0) > > This was a buggy patch in a branch, already updated and can be discarded. > Then let's do: #syz invalid