Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Mon, 16 Jan 2023 17:06:52 +0100
From:   Christoph Hellwig <hch@lst.de>
To:     Jan Kara <jack@suse.cz>
Cc:     Christoph Hellwig <hch@lst.de>, jack@suse.com,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext2: propagate errors from ext2_prepare_chunk
Message-ID: <20230116160652.GA23301@lst.de>
References: <20230116085205.2342975-1-hch@lst.de> <20230116111621.rffhrhkdggszwlnu@quack3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230116111621.rffhrhkdggszwlnu@quack3>
User-Agent: Mutt/1.5.17 (2007-11-01)
Precedence: bulk

On Mon, Jan 16, 2023 at 12:16:21PM +0100, Jan Kara wrote:
> > -		ext2_set_link(new_dir, new_de, new_page, page_addr, old_inode, 1);
> > +		err = ext2_set_link(new_dir, new_de, new_page, page_addr,
> > +				    old_inode, true);
> > +		if (err)
> > +			goto out_dir;
> >  		ext2_put_page(new_page, page_addr);
> 
> AFAICT we need to call ext2_put_page(new_page, page_addr) also in case of
> error here. I'll fix it up on commit. Thanks for the patch.

Indeed.  I was tricked by out_dir doing the cleanup, but that's for
the old entry.