Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp5890151rwb; Tue, 17 Jan 2023 21:05:32 -0800 (PST) X-Google-Smtp-Source: AMrXdXuGet62CX9unKjosO5M07DrsU7ahp5OMueVvXU3A9Ft7GRzXvH8XmNDRewOwBZaLemAR0qr X-Received: by 2002:a17:902:eb89:b0:194:997d:7735 with SMTP id q9-20020a170902eb8900b00194997d7735mr5085898plg.48.1674018331788; Tue, 17 Jan 2023 21:05:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674018331; cv=none; d=google.com; s=arc-20160816; b=ZyF9XRLAOo4xE0ZP+RgylDKMvENsuscsS3oFkTMFKcNTlauRF9VcTPDi/ZfT7BFYdf i0AIAx1MXTIo9Dv2BjWcX8K9oYFFosGlpAnry67/1BfHa8H+8UH6p5FkjyxFu0Rg4Jem RhuV1o94KqNrjYa5Fq4NBY68blDbXU4cKIuYI2agryvFGp1icMmVA4Lfvv57LGeXDLbT WODyHr2BNa73fCvRQzuAow901Fa8lQQYFLP1c0Y4gnZXb/0uyPfJn4IWldpVkhheYfE2 XYs49y3oN3g8y9Er4YN9TVvfbgN7XbwvRUMhBNkHJC+6OQIDTa/TSyRw6pUYPJVU68xn ae7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=J0YNuNxVJcKA1epCU6rBwBHwCpFPV2DH5FfnlQx487g=; b=FMq6B7dYJXr8ASCD6GIIwOuHYhPyr92DRoRJPVPirlzGBrkr8KiJKXMs6xLBbI0cUq Z3oVSAkBU2CpNPQqpnECnKk8GbOKXwHOnLNGDYvHpn3zjH9orH+HCMcZZVnDj8xMK6kv k1SMNPl44A7B73Ywjg2CG6amt5d10Xr5+F19yhOINKpTeYHE5JimjwM9zyWHcAjZl4ge sf6jZM3rxWmMM7x4FvTeFrW5E9Ej58lRrH2Rwr1c2MthMfQ27DgxZodrT2LBM64u6EYs 0dHXz56YGsNHcSPhTXnxggfW2kr6LpVIhQLw0Yoml1mbPTROamsWSCVIXlCBfzQ44Er5 bMFw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z4-20020a170902ccc400b00172cb948c68si33854946ple.227.2023.01.17.21.05.15; Tue, 17 Jan 2023 21:05:31 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229525AbjAREyT (ORCPT + 99 others); Tue, 17 Jan 2023 23:54:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57836 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229468AbjAREyS (ORCPT ); Tue, 17 Jan 2023 23:54:18 -0500 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BE32F50840 for ; Tue, 17 Jan 2023 20:54:16 -0800 (PST) Received: from canpemm500009.china.huawei.com (unknown [172.30.72.55]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NxYKB5L1Dz16N2W; Wed, 18 Jan 2023 12:52:30 +0800 (CST) Received: from huawei.com (10.113.189.238) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 18 Jan 2023 12:54:13 +0800 From: Wang Jianjian To: , CC: , Subject: [PATCH] ext4: Don't show commit interval if it is zero Date: Wed, 18 Jan 2023 12:54:13 +0800 Message-ID: <20230118045413.3537040-1-wangjianjian3@huawei.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.113.189.238] X-ClientProxiedBy: dggems704-chm.china.huawei.com (10.3.19.181) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org If commit interval is 0, it means using default value. Fixes: 6e47a3cc68fc ("ext4: get rid of super block and sbi from handle_mount_ops()") Signed-off-by: Wang Jianjian Reviewed-by: Lukas Czerner --- fs/ext4/super.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 260c1b3e3ef2..3b9e30e1afd9 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -2146,7 +2146,7 @@ static int ext4_parse_param(struct fs_context *fc, struct fs_parameter *param) return 0; case Opt_commit: if (result.uint_32 == 0) - ctx->s_commit_interval = JBD2_DEFAULT_MAX_COMMIT_AGE; + result.uint_32 = JBD2_DEFAULT_MAX_COMMIT_AGE; else if (result.uint_32 > INT_MAX / HZ) { ext4_msg(NULL, KERN_ERR, "Invalid commit interval %d, " -- 2.32.0