Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp6740236rwb; Wed, 18 Jan 2023 08:49:12 -0800 (PST) X-Google-Smtp-Source: AMrXdXuYFK0aiP7a1/HpsqrrTUxUEeKc68Gx1QSILGDLkujZj33X1s1x1AIkWfAu/yAmEcN0tXk3 X-Received: by 2002:a17:902:b20f:b0:194:a268:1201 with SMTP id t15-20020a170902b20f00b00194a2681201mr7540249plr.43.1674060551823; Wed, 18 Jan 2023 08:49:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674060551; cv=none; d=google.com; s=arc-20160816; b=USYhQBIitDfN6U+CNWTI6K1+HvxgnspviVktJp8bP/UddqJPHmjzoMl/QVcVk083TA YaQRDsDP58AOIL09jz9tNaAIi2k/cWtFTEkqyD8yviopH3MDTYgAGe86AMwEaZ3B27sm jtaos7KOHH5/Aycoj7fsySTOfNnCwsA2EllPmFAtKj4Dl+J8iyYl37tdHT8I+bDQkiM7 EpTUozPJ4qZwkObR7o+LmAvMbn73CmRyEwKbXq1I3Ve28643E9sgvcrdzJvf+vweTvpd VOMOCP1dH2XS3XJFXjEoH1Cv4k1WhTAdPed/e8cHxlgg/6Se/CLBYbcMqDbc4tFuSh37 GRvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=Y1RWaMgExx6Sevf+OPnH4ZTjbdCF9nCvVAtozvfTeZc=; b=bbDEEzVv8a6r8DhtBuMsmjM8aa7OY4WunfLf+LFD4jqWsCbaZsA8P0HIUOs58MrJMH EkrWwDf+gQ9FSPTRzLO4F2b8+k88x/BpZHlGe1xOeZkHivrCcmoVkcRVue2zzSc/gu2h m+3gcIP8ft8sIQmVcSWfqP9NXiS9d0/J/CsSt7461prP77C3ubCKRsqpSsC3oMTW0r38 4qFKmYwevEsDA6TmF25a+aDOEMxnHxU8E19MMfjFdOpuHWTqFvJCsXAUOK4J5pVf2GCE pe2s7aEMcaHh8vKDk8M25nMHUxPhfiLwast8/gJArSAb7TJy8wf6HiYbBck9paYQ2UWT EkQA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k23-20020a634b57000000b00478bf0b11b1si35586687pgl.752.2023.01.18.08.48.58; Wed, 18 Jan 2023 08:49:11 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230339AbjARQnd (ORCPT + 99 others); Wed, 18 Jan 2023 11:43:33 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230366AbjARQnH (ORCPT ); Wed, 18 Jan 2023 11:43:07 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1520837B76; Wed, 18 Jan 2023 08:42:37 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id AB09068AFE; Wed, 18 Jan 2023 17:42:34 +0100 (CET) Date: Wed, 18 Jan 2023 17:42:34 +0100 From: Christoph Hellwig To: Andreas Gruenbacher Cc: Matthew Wilcox , Christoph Hellwig , linux-xfs@vger.kernel.org, linux-nilfs@vger.kernel.org, Hugh Dickins , cluster-devel@redhat.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Andrew Morton , linux-ext4@vger.kernel.org, linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org Subject: Re: [Cluster-devel] [PATCH 7/9] gfs2: handle a NULL folio in gfs2_jhead_process_page Message-ID: <20230118164234.GB7584@lst.de> References: <20230118094329.9553-1-hch@lst.de> <20230118094329.9553-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Wed, Jan 18, 2023 at 05:24:32PM +0100, Andreas Gruenbacher wrote: > We're actually still holding a reference to the folio from the > find_or_create_page() in gfs2_find_jhead() here, so we know that > memory pressure can't push the page out and filemap_get_folio() won't > return NULL. Ok, I'll drop this patch.