Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     zhanchengbin <zhanchengbin1@huawei.com>
Cc:     "Theodore Ts'o" <tytso@mit.edu>,
        linfeilong <linfeilong@huawei.com>, liuzhiqiang26@huawei.com,
        Lukas Czerner <lczerner@redhat.com>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH v2] misc/fsck.c: Processes may kill other processes.
Date:   Thu, 19 Jan 2023 10:27:08 -0500
Message-Id: <167414201626.2737146.2771008516918347925.b4-ty@mit.edu>
In-Reply-To: <2c8f3b3a-b6d1-9b8b-27c7-2df51236fe8c@huawei.com>
References: <2c8f3b3a-b6d1-9b8b-27c7-2df51236fe8c@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 10 Oct 2022 16:56:58 +0800, zhanchengbin wrote:
> I find a error in misc/fsck.c, if run the fsck -N command, processes
> don't execute, just show what would be done. However, the pid whose
> value is -1 is added to the instance_list list in the execute
> function,if the kill_all function is called later, kill(-1, signum)
> is executed, Signals are sent to all processes except the number one
> process and itself. Other processes will be killed if they use the
> default signal processing function.
> 
> [...]

Applied, thanks!

[1/1] misc/fsck.c: Processes may kill other processes.
      commit: d08ef863feae14e4710bf2026404e6c6e06db2be

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>