Received: by 2002:a05:6358:a55:b0:ec:fcf4:3ecf with SMTP id 21csp4141504rwb; Sat, 21 Jan 2023 06:33:02 -0800 (PST) X-Google-Smtp-Source: AMrXdXtLWgrxmV3HxTQrrxV1dl7wC+YmZhOT94zYw09R/Pj7aWo+R6FTHiJV61F/MXUsqw23mgeu X-Received: by 2002:a17:906:ecb9:b0:874:9ac1:40e with SMTP id qh25-20020a170906ecb900b008749ac1040emr16852482ejb.19.1674311582107; Sat, 21 Jan 2023 06:33:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1674311582; cv=none; d=google.com; s=arc-20160816; b=wjkrnVtyvjeiZShLu/GejKb+WcyAcVsoImUGJjt8Y2Vfl5CE588PT7tXgt2HJt2d+j w12jAlfRWIZ7TXv011kP1nLXTgUxkcTFbo1bMC1uHmsXoYGfkV40YpZ6vwtGBjVFN5Ys CvaAT0NjlMVe9T7z4sWapitkRhaJuzOoDcOLHKWiHZPsGVw9fQ9v0EfETPk3j+SrCl6x nnRE1NPwLeBcesrmZ5P4Y8IX0JJ835kRBEBIZuQobSaw4hDW3ZymLr+V3RTz+XgzEaRX KUWbt5rWYkpktjxtnbvUzBcBjbfLTxZq7Joex2DCVBp38FCNnUmFdSldYgQFp5gCTNQI sp0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=1AdXcQJG1XWVRa2csTvjE1zXSCuzDdrHU3NdMMnXHYA=; b=kCle/cRRQi08QohE47+DRL4LvpoLWRzC7VkCxQxc+lfn1s4YeRtLPaF00OOt7qNYEM 3lffQFfXe3ErFGrS8TSR5lsCwdRRM7cfQUYuN3IOOn6Lwdxp3FJHUfVrjFgx+19rh6U8 lJ2W4k/ZfiQlIRGzMG6hc+RLukUpd6bRF1wcpYmxWfGcWNz4pGMFJ/6/KHoTSFKpNFk9 zHocRP4a/ItPXISJctsAJbkka3hjxC7OIUkGtozP8Ht9lmn+WxG2bawChhjwFSePTNXS VjNVm9A8BhpHS2oJwJUm+M+JZiPzVHnEme/4r2ES8KSNZ3B6PR70XkoynCMFHEdtjc6L JwZA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d11-20020a50c88b000000b0048b6bca0c4bsi41696095edh.565.2023.01.21.06.32.35; Sat, 21 Jan 2023 06:33:02 -0800 (PST) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229759AbjAUO2W (ORCPT + 99 others); Sat, 21 Jan 2023 09:28:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60034 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229484AbjAUO2W (ORCPT ); Sat, 21 Jan 2023 09:28:22 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0D1D921A07; Sat, 21 Jan 2023 06:28:20 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id 70C3668CFE; Sat, 21 Jan 2023 15:28:16 +0100 (CET) Date: Sat, 21 Jan 2023 15:28:15 +0100 From: Christoph Hellwig To: kernel test robot Cc: Christoph Hellwig , Andrew Morton , Matthew Wilcox , Hugh Dickins , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-afs@lists.infradead.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, cluster-devel@redhat.com, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-nilfs@vger.kernel.org Subject: Re: [PATCH 7/7] mm: return an ERR_PTR from __filemap_get_folio Message-ID: <20230121142815.GA6786@lst.de> References: <20230121065755.1140136-8-hch@lst.de> <202301211944.5T9l1RgA-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202301211944.5T9l1RgA-lkp@intel.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE, SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, Jan 21, 2023 at 07:52:54PM +0800, kernel test robot wrote: > Hi Christoph, > > I love your patch! Perhaps something to improve: And I don't love all this hugging when something doesn't work. It feels passive aggressive. That being said, in this case the error is becaue the series is against linux-next, so applying it to mainline won't work.