From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Li Dongyang <dongyangli@ddn.com>, linux-ext4@vger.kernel.org
Cc:     "Theodore Ts'o" <tytso@mit.edu>, adilger@dilger.ca
Subject: Re: [PATCH] e2fsck: optimize clone_file on large devices
Date:   Wed, 25 Jan 2023 22:50:55 -0500
Message-Id: <167470504132.8995.9766202525673034373.b4-ty@mit.edu>
In-Reply-To: <20221219130544.259410-1-dongyangli@ddn.com>
References: <20221219130544.259410-1-dongyangli@ddn.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Tue, 20 Dec 2022 00:05:44 +1100, Li Dongyang wrote:
> When cloning multiply-claimed blocks for an inode,
> clone_file() uses ext2fs_block_iterate3() to iterate
> every block calling clone_file_block().
> clone_file_block() calls check_if_fs_cluster(), even
> the block is not on the block_dup_map, which could take
> a long time on a large device.
> 
> [...]

Applied, thanks!

[1/1] e2fsck: optimize clone_file on large devices
      commit: 6cae615a47dfe37fe5fd096accb82579813a6366

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>