Subject: Re: [RFC PATCH 2/2] ext4: add journal cycled recording support
To:     kernel test robot <yujie.liu@intel.com>
Cc:     oe-lkp@lists.linux.dev, lkp@intel.com, linux-ext4@vger.kernel.org,
        tytso@mit.edu, adilger.kernel@dilger.ca, jack@suse.cz,
        yi.zhang@huawei.com, yukuai3@huawei.com
References: <202301301621.30292a65-yujie.liu@intel.com>
From:   Zhang Yi <yi.zhang@huaweicloud.com>
Message-ID: <01625b14-a998-3c94-46dd-c13d1fc077dd@huaweicloud.com>
Date:   Wed, 1 Feb 2023 17:29:40 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <202301301621.30292a65-yujie.liu@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello

On 2023/1/30 17:19, kernel test robot wrote:
> Greeting,
> 
> FYI, we noticed xfstests.ext4.053.fail due to commit (built with gcc-11):
> 
> commit: 8ed4c906ef9a43941026aad0360d84a9338e1c4c ("[RFC PATCH 2/2] ext4: add journal cycled recording support")
> url: https://github.com/intel-lab-lkp/linux/commits/Zhang-Yi/jbd2-cycled-record-log-on-clean-journal-logging-area/20230119-131055
> base: https://git.kernel.org/cgit/linux/kernel/git/tytso/ext4.git dev
> patch link: https://lore.kernel.org/all/20230119034600.3431194-3-yi.zhang@huaweicloud.com/
> patch subject: [RFC PATCH 2/2] ext4: add journal cycled recording support
> 
> in testcase: xfstests
> version: xfstests-x86_64-fb6575e-1_20230116
> with following parameters:
> 
> 	disk: 4HDD
> 	fs: ext2
> 	test: ext4-group-02
> 
> test-description: xfstests is a regression test suite for xfs and other files ystems.
> test-url: git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git
> 
> on test machine: 4 threads Intel(R) Core(TM) i5-6500 CPU @ 3.20GHz (Skylake) with 32G memory
> 
> caused below changes (please refer to attached dmesg/kmsg for entire log/backtrace):
> 
> 
> QA output created by 053
> Silence is golden.
> mounting ext3 "noload" checking "norecovery" (going to remount options noload) (failed remount) FAILED
> mounting ext3 "noload" checking "noload" (going to remount options noload) (failed remount) FAILED
> mounting ext3 "data=journal" (failed mount) FAILED
> mounting ext3 "data=journal" (failed mount) FAILED
> mounting ext3 "data=ordered" (failed mount) FAILED
> mounting ext3 "data=ordered" (failed mount) FAILED
> mounting ext3 "data=writeback" (failed mount) FAILED
> mounting ext3 "data=writeback" (failed mount) FAILED
> mkfs failed - /usr/sbin/mkfs.ext4 -Fq -J device=/dev/loop0 /dev/sda4 1048576k /dev/sda4
> 
> 

This is a separate issue and could be fixed by "[PATCH] ext4: fix incorrect options show of original mount_opt and extend mount_opt2",
https://lore.kernel.org/linux-ext4/20230130111138.76tp6pij3yhh4brh@quack3/T/#m96a1cffd567bdd844233b3115a6635391ed0b45b

Thanks,
Yi.