Date:   Thu, 16 Feb 2023 17:39:02 +0530
Message-Id: <87mt5dn76p.fsf@doe.com>
From:   Ritesh Harjani <ritesh.list@gmail.com>
To:     Eric Whitney <enwlinux@gmail.com>, linux-ext4@vger.kernel.org
Cc:     tytso@mit.edu, Eric Whitney <enwlinux@gmail.com>
Subject: Re: [PATCH] ext4: fix RENAME_WHITEOUT handling for inline directories
In-Reply-To: <20230210173244.679890-1-enwlinux@gmail.com>
Precedence: bulk

Eric Whitney <enwlinux@gmail.com> writes:

> A significant number of xfstests can cause ext4 to log one or more
> warning messages when they are run on a test file system where the
> inline_data feature has been enabled.  An example:
>
> "EXT4-fs warning (device vdc): ext4_dirblock_csum_set:425: inode
>  #16385: comm fsstress: No space for directory leaf checksum. Please
> run e2fsck -D."
>
> The xfstests include: ext4/057, 058, and 307; generic/013, 051, 068,
> 070, 076, 078, 083, 232, 269, 270, 390, 461, 475, 476, 482, 579, 585,
> 589, 626, 631, and 650.

So, I guess since these were only ext4 warnings hence maybe these were
getting ignored? Because the tests were never failing?
Should we do something for such cases? Maybe adding this warning
detection in xfstests to fail the test case when these warnings are not
intended? e.g. such warnings should make the test fail by saying
something detected in dmesg. Except when these are expected for I/O error
injection tests, etc...

>
> In this situation, the warning message indicates a bug in the code that
> performs the RENAME_WHITEOUT operation on a directory entry that has
> been stored inline.  It doesn't detect that the directory is stored
> inline, and incorrectly attempts to compute a dirent block checksum on
> the whiteout inode when creating it.  This attempt fails as a result
> of the integrity checking in get_dirent_tail (usually due to a failure
> to match the EXT4_FT_DIR_CSUM magic cookie), and the warning message
> is then emitted.
>
> Fix this by simply collecting the inlined data state at the time the
> search for the source directory entry is performed.  Existing code
> handles the rest, and this is sufficient to eliminate all spurious
> warning messages produced by the tests above.  Go one step further
> and do the same in the code that resets the source directory entry in
> the event of failure.  The inlined state should be present in the
> "old" struct, but given the possibility of a race there's no harm
> in taking a conservative approach and getting that information again
> since the directory entry is being reread anyway.

Thanks for the detailed explaination. This makes sense to me.

>
> Fixes: b7ff91fd030d ("ext4: find old entry again if failed to rename whiteout")

So for your changes in ext4_resetent(), your above fixes tags make sense.
But what about the changes in ext4_rename() function. That was always
passing NULL as the last argument since the begining no?
Thinking from the backport perspective if and when required ;)


>
> Signed-off-by: Eric Whitney <enwlinux@gmail.com>
> ---
>  fs/ext4/namei.c | 13 +++++++------
>  1 file changed, 7 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ext4/namei.c b/fs/ext4/namei.c
> index dd28453d6ea3..924e16b239e0 100644
> --- a/fs/ext4/namei.c
> +++ b/fs/ext4/namei.c
> @@ -1595,11 +1595,10 @@ static struct buffer_head *__ext4_find_entry(struct inode *dir,
>  		int has_inline_data = 1;
>  		ret = ext4_find_inline_entry(dir, fname, res_dir,
>  					     &has_inline_data);
> -		if (has_inline_data) {
> -			if (inlined)
> -				*inlined = 1;
> +		if (inlined)
> +			*inlined = has_inline_data;
> +		if (has_inline_data)
>  			goto cleanup_and_exit;
> -		}
>  	}

This looks like a nice cleanup!!

>
>  	if ((namelen <= 2) && (name[0] == '.') &&
> @@ -3646,7 +3645,8 @@ static void ext4_resetent(handle_t *handle, struct ext4_renament *ent,
>  	 * so the old->de may no longer valid and need to find it again
>  	 * before reset old inode info.
>  	 */
> -	old.bh = ext4_find_entry(old.dir, &old.dentry->d_name, &old.de, NULL);
> +	old.bh = ext4_find_entry(old.dir, &old.dentry->d_name, &old.de,
> +				 &old.inlined);
>  	if (IS_ERR(old.bh))
>  		retval = PTR_ERR(old.bh);
>  	if (!old.bh)
> @@ -3813,7 +3813,8 @@ static int ext4_rename(struct user_namespace *mnt_userns, struct inode *old_dir,
>  			return retval;
>  	}
>
> -	old.bh = ext4_find_entry(old.dir, &old.dentry->d_name, &old.de, NULL);
> +	old.bh = ext4_find_entry(old.dir, &old.dentry->d_name, &old.de,
> +				 &old.inlined);
>  	if (IS_ERR(old.bh))
>  		return PTR_ERR(old.bh);
>  	/*
> --
> 2.30.2