Date:   Thu, 16 Feb 2023 18:26:07 +0530
Message-Id: <87k00hn508.fsf@doe.com>
From:   Ritesh Harjani <ritesh.list@gmail.com>
To:     Li kunyu <kunyu@nfschina.com>, tytso@mit.edu,
        adilger.kernel@dilger.ca
Cc:     linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        Li kunyu <kunyu@nfschina.com>
Subject: Re: [PATCH] ext4: ialloc: Remove variables defined more than once in a function
In-Reply-To: <20230207233632.4723-1-kunyu@nfschina.com>
Precedence: bulk

Li kunyu <kunyu@nfschina.com> writes:

> The grp pointer variable has been defined at the beginning of the
> function. It is not necessary to define it here, so remove the variable
> definition here.
>
> Signed-off-by: Li kunyu <kunyu@nfschina.com>
> ---
>  fs/ext4/ialloc.c | 1 -
>  1 file changed, 1 deletion(-)

Looks good to me. Please feel free to add -

Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>

>
> diff --git a/fs/ext4/ialloc.c b/fs/ext4/ialloc.c
> index 63f9bb6e8851..be9f742f9415 100644
> --- a/fs/ext4/ialloc.c
> +++ b/fs/ext4/ialloc.c
> @@ -1181,7 +1181,6 @@ struct inode *__ext4_new_inode(struct user_namespace *mnt_userns,
>  	/* Update the relevant bg descriptor fields */
>  	if (ext4_has_group_desc_csum(sb)) {
>  		int free;
> -		struct ext4_group_info *grp = NULL;
>
>  		if (!(sbi->s_mount_state & EXT4_FC_REPLAY)) {
>  			grp = ext4_get_group_info(sb, group);
> --
> 2.18.2