From:   "Theodore Ts'o" <tytso@mit.edu>
To:     linux-ext4@vger.kernel.org, Zhang Yi <yi.zhang@huaweicloud.com>
Cc:     "Theodore Ts'o" <tytso@mit.edu>, yi.zhang@huawei.com,
        yukuai3@huawei.com, adilger.kernel@dilger.ca, jack@suse.cz
Subject: Re: [RFC PATCH v2] ext4: dio take shared inode lock when overwriting preallocated blocks
Date:   Sun, 19 Feb 2023 00:40:53 -0500
Message-Id: <167678522161.2723470.15996894909319894248.b4-ty@mit.edu>
In-Reply-To: <20221226062015.3479416-1-yi.zhang@huaweicloud.com>
References: <20221226062015.3479416-1-yi.zhang@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Mon, 26 Dec 2022 14:20:15 +0800, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> In the dio write path, we only take shared inode lock for the case of
> aligned overwriting initialized blocks inside EOF. But for overwriting
> preallocated blocks, it may only need to split unwritten extents, this
> procedure has been protected under i_data_sem lock, it's safe to
> release the exclusive inode lock and take shared inode lock.
> 
> [...]

Applied, thanks!

[1/1] ext4: dio take shared inode lock when overwriting preallocated blocks
      commit: 240930fb7e6b52229bdee5b1423bfeab0002fed2

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>