Date:   Thu, 23 Feb 2023 22:47:05 -0500
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     zhanchengbin <zhanchengbin1@huawei.com>
Cc:     linux-ext4@vger.kernel.org, linfeilong@huawei.com,
        louhongxiang@huawei.com
Subject: Re: [PATCH v2] lib/ext2fs: add some msg for io error
Message-ID: <Y/gzOSmW70rXcjvq@mit.edu>
References: <20230223090111.680573-1-zhanchengbin1@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230223090111.680573-1-zhanchengbin1@huawei.com>
Precedence: bulk

On Thu, Feb 23, 2023 at 05:01:11PM +0800, zhanchengbin wrote:
> Add msgs to show whether there is eio in fsck process, when write and
> fsync methods fail.
> 
> Signed-off-by: zhanchengbin <zhanchengbin1@huawei.com>

The libext2fs is a *library*.  As such, well designed libraries do not
randomly write to stderr.  Consider what might happen if there was a
curses based program that was calling libext2fs --- for example, like
the ext2ed program.  Writing random errors to stderr is just *rude*.   :-)

If what you're worried about errors from e2fsck, it's also not
necessary, since that's what the error handler callback is for.

Cheers,

					- Ted