Date:   Wed, 1 Mar 2023 14:05:12 +0100
From:   Jan Kara <jack@suse.cz>
To:     Tudor Ambarus <tudor.ambarus@linaro.org>
Cc:     Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org,
        syzbot+4fec412f59eba8c01b77@syzkaller.appspotmail.com
Subject: Re: [PATCH 2/2] ext2: Check block size validity during mount
Message-ID: <20230301130512.2vunrj4mspbkwgah@quack3>
References: <20230301111026.15102-1-jack@suse.cz>
 <20230301111238.22856-2-jack@suse.cz>
 <d2a5be55-4bcb-da7e-fae5-9cc598223b17@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d2a5be55-4bcb-da7e-fae5-9cc598223b17@linaro.org>
Precedence: bulk

On Wed 01-03-23 11:37:20, Tudor Ambarus wrote:
> Hi!
> 
> On 3/1/23 11:12, Jan Kara wrote:
> > Check that log of block size stored in the superblock has sensible
> > value. Otherwise the shift computing the block size can overflow leading
> > to undefined behavior.
> > 
> > Reported-by: syzbot+4fec412f59eba8c01b77@syzkaller.appspotmail.com
> 
> Would be helpful to also have:
> LINK: https://syzkaller.appspot.com/bug?extid=4fec412f59eba8c01b77
> a "Fixes:" tag and
> Cc: stable@vger.kernel.org

Well, Fixes tag doesn't really make sense here. The behavior is there since
forever... I've added the Link and CC tags. Thanks for the suggestion.

								Honza

-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR