Date:   Tue, 7 Mar 2023 12:08:30 +0100
From:   Jan Kara <jack@suse.cz>
To:     Kemeng Shi <shikemeng@huaweicloud.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        linfeilong@huawei.com
Subject: Re: [PATCH 3/4] ext4: remove unused group parameter in
 ext4_block_bitmap_csum_verify
Message-ID: <20230307110830.w7nuk3mrgjgfezig@quack3>
References: <20230221203027.2359920-1-shikemeng@huaweicloud.com>
 <20230221203027.2359920-4-shikemeng@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230221203027.2359920-4-shikemeng@huaweicloud.com>
Precedence: bulk

On Wed 22-02-23 04:30:26, Kemeng Shi wrote:
> Remove unused group parameter in ext4_block_bitmap_csum_verify.
> 
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>

Looks good. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/balloc.c | 3 +--
>  fs/ext4/bitmap.c | 2 +-
>  fs/ext4/ext4.h   | 2 +-
>  3 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/ext4/balloc.c b/fs/ext4/balloc.c
> index 689edfed231a..49fdb758b0e4 100644
> --- a/fs/ext4/balloc.c
> +++ b/fs/ext4/balloc.c
> @@ -385,8 +385,7 @@ static int ext4_validate_block_bitmap(struct super_block *sb,
>  	ext4_lock_group(sb, block_group);
>  	if (buffer_verified(bh))
>  		goto verified;
> -	if (unlikely(!ext4_block_bitmap_csum_verify(sb, block_group,
> -						    desc, bh) ||
> +	if (unlikely(!ext4_block_bitmap_csum_verify(sb, desc, bh) ||
>  		     ext4_simulate_fail(sb, EXT4_SIM_BBITMAP_CRC))) {
>  		ext4_unlock_group(sb, block_group);
>  		ext4_error(sb, "bg %u: bad block bitmap checksum", block_group);
> diff --git a/fs/ext4/bitmap.c b/fs/ext4/bitmap.c
> index 0186b894f5b3..3b83d979a650 100644
> --- a/fs/ext4/bitmap.c
> +++ b/fs/ext4/bitmap.c
> @@ -54,7 +54,7 @@ void ext4_inode_bitmap_csum_set(struct super_block *sb,
>  		gdp->bg_inode_bitmap_csum_hi = cpu_to_le16(csum >> 16);
>  }
>  
> -int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,
> +int ext4_block_bitmap_csum_verify(struct super_block *sb,
>  				  struct ext4_group_desc *gdp,
>  				  struct buffer_head *bh)
>  {
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index aa6948d12ede..04447640b4f4 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -2685,7 +2685,7 @@ int ext4_inode_bitmap_csum_verify(struct super_block *sb,
>  void ext4_block_bitmap_csum_set(struct super_block *sb, ext4_group_t group,
>  				struct ext4_group_desc *gdp,
>  				struct buffer_head *bh);
> -int ext4_block_bitmap_csum_verify(struct super_block *sb, ext4_group_t group,
> +int ext4_block_bitmap_csum_verify(struct super_block *sb,
>  				  struct ext4_group_desc *gdp,
>  				  struct buffer_head *bh);
>  
> -- 
> 2.30.0
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR