From:   Yangtao Li <frank.li@vivo.com>
To:     tytso@mit.edu, adilger.kernel@dilger.ca
Cc:     linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        viro@zeniv.linux.org.uk, hsiangkao@linux.alibaba.com,
        linux-erofs@lists.ozlabs.org
Subject: Re: [PATCH] ext4: convert to DIV_ROUND_UP() in mpage_process_page_bufs()
Date:   Fri, 10 Mar 2023 14:27:38 +0800
Message-Id: <20230310062738.69663-1-frank.li@vivo.com>
In-Reply-To: <ZArLbO1ckmcXwQf0@sol.localdomain>
References: <ZArLbO1ckmcXwQf0@sol.localdomain>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Ao4UfX94nT8y3v1hpJIi4Dvk5eng64tC5F4Qpez+TD1kWgF0/s7VnnRdjbCD?=
 =?us-ascii?Q?DBRyAewjF2V9N0pd6viWjZR0hVT8Ca2QwJKi9g90gNohIgNfQ66/PFKRMX8/?=
 =?us-ascii?Q?wMnmJ5WlbpQ/l0aLk+kENKnmZWggKAobFIj4ksQxax8SPFcIfprMSfzEz3L8?=
 =?us-ascii?Q?luJtqJvNsIH4LVhm2pg3VrCuZUgrCgfYbzpXigLCkVJmp98pFQsURp4fhS1r?=
 =?us-ascii?Q?JuCu7LVJNsaOhtfVAiMfiwd5lsnHyA4nyXhtB9FActAtYySLycdT0RtGcGMc?=
 =?us-ascii?Q?PSzXiDy7gXvaUDQzFHOEWOAzYD5GIVgckfvzDccIdxQy6lEjrrWtMc011d75?=
 =?us-ascii?Q?vs2rSocY2Ay3dub9veQUebAQR/2Otl0bOq8mUmt8Cj219qli0a7cyn74SMpt?=
 =?us-ascii?Q?C14edOW6qz8l2rXYZVSGZ7ZtsXEaMCSjxii4RVRFBzhnc/zURdWgeebfgm93?=
 =?us-ascii?Q?iHz/qfH2PouI+Lsc55Q/ZqjWOJhLr8kOsbfXBYcrx6TbTM4Q3INhg1qh+80S?=
 =?us-ascii?Q?sNEfL1ZEQjoC8h4qm0uSl3ycWL67G48rItNF6ru0DqWGrgK6z4ViTdYbiq8D?=
 =?us-ascii?Q?deuvajspvrrsG9DyYaSG6CplX8a7IxdSGc9QDZ/IoNJ53d0gMwsnzJEkMxa4?=
 =?us-ascii?Q?n0mwRKfK+prse0Zqb0q3v+puZbe+AgI9Ifcr5tT/5gueFGYZaJ9eu4v4yqIi?=
 =?us-ascii?Q?vDccXilhERJKeQOv7Wx0PaGi5/+kde9wT5vZfDDoyIypFNPqEjHKwFYerLWp?=
 =?us-ascii?Q?b8XLtetnAWdVVErCGucBQxHpF9igSIeoLHRcjhFwgeClmbCrwiSsrJlFov5F?=
 =?us-ascii?Q?0ClkktNDS3W1J6r3maJkgMHgKT38JqrIObT62TVyBGAZfl1oCrQfDuKJyMcc?=
 =?us-ascii?Q?GbBfCNDr9SU3wULq2VOCPoUWrwfmRLmca3xqjrGS0XlgmIYhXkiGAzxs21qK?=
 =?us-ascii?Q?Hzu+Ju/pZpUCekCl0+sLnwpeNm68166Ykmyrxhh7q5pHkFwiAQfTIr3ghyoA?=
 =?us-ascii?Q?VQvCKk6ORxV0R8a8ccN4lVw/HcQZUjpGhJr0l4dpWu9Fi3PkZyrEpuOawc7t?=
 =?us-ascii?Q?lha834KzvGui2Kkcfzv2aHYLcZ/3O/5b5l0vBaY/5Yds86XEkz0dd/0Rx2No?=
 =?us-ascii?Q?vANZBSL2/iR0Mz9CxiHRaH7a6jrfFoj1k+aoOldXg5t7hGckZxxXlsREHiAD?=
 =?us-ascii?Q?eoeggJMnU7HHaoFbCs14twuH90TfJSvKrN6oB+8FMFZK6AUYFsBuKi7f7UH5?=
 =?us-ascii?Q?ObTFwMi/T2IQ457kL25rn9mS8/Zeac6UTH6sdCC7rhnuqS6pCXSDOqwSMyW/?=
 =?us-ascii?Q?x/lR9DtkQtQ42F8oM1p+IHYO/2RqAeKuwiNzMldsWXConAw9MtBeQv2WlPPu?=
 =?us-ascii?Q?Fe0htAtd3tX0ZojCCGLs4QeHYgFwvo2fiq4GocR/s+efkPV86MDwFurlD+CO?=
 =?us-ascii?Q?n6FwVBdWfv/f6APZh9hP2AHQKZ+IXOMHnxX15cnj3J7Me91M9RmNDMpcnsZl?=
 =?us-ascii?Q?Z58vKfE3rxKdlf8u8lyh0hS7iM4kIgchUqbycuC7lHH5C3YxcufXfSmjF9Sb?=
 =?us-ascii?Q?UZdFaKcbtmr2pluKo6+W4huYvjvJOFoFs6QoR94T?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26e0269e-2717-4f47-7b85-08db213091a0
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB5269.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Mar 2023 06:27:49.0917
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MeGq3mpujLFBZ24ee9ZXRdo1pFcfDVkq1cZRZrxX1rOZDL4Ejacwh2PJNuwiYf/5T+4YwEbDq+tWhzTOGEUYzQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB5534
Precedence: bulk
List-ID: <linux-ext4.vger.kernel.org>
X-Mailing-List: linux-ext4@vger.kernel.org

> Please don't do this.  This makes the code compile down to a division, which is
> far less efficient.  I've verified this by checking the assembly generated.

How much is the performance impact? So should the following be modified as shift operations as well?

fs/erofs/namei.c:92:    int head = 0, back = DIV_ROUND_UP(dir->i_size, EROFS_BLKSIZ) - 1;
fs/erofs/zmap.c:252:    const unsigned int totalidx = DIV_ROUND_UP(inode->i_size, EROFS_BLKSIZ);
fs/erofs/decompressor.c:14:#define LZ4_MAX_DISTANCE_PAGES       (DIV_ROUND_UP(LZ4_DISTANCE_MAX, PAGE_SIZE) + 1)
fs/erofs/decompressor.c:56:                                     DIV_ROUND_UP(distance, PAGE_SIZE) + 1 :
fs/erofs/decompressor.c:70:     unsigned long bounced[DIV_ROUND_UP(LZ4_MAX_DISTANCE_PAGES,
fs/erofs/data.c:84:     nblocks = DIV_ROUND_UP(inode->i_size, EROFS_BLKSIZ);

Thx,
Yangtao