From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     "Theodore Ts'o" <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH] ext4: Fix warnings when freezing filesystem with journaled data
Date:   Wed, 15 Mar 2023 12:16:11 -0400
Message-Id: <167889696171.3024151.1866086875866580261.b4-ty@mit.edu>
In-Reply-To: <20230308142528.12384-1-jack@suse.cz>
References: <20230308142528.12384-1-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Wed, 8 Mar 2023 15:25:28 +0100, Jan Kara wrote:
> Test generic/390 in data=journal mode often triggers a warning that
> ext4_do_writepages() tries to start a transaction on frozen filesystem.
> This happens because although all dirty data is properly written, jbd2
> checkpointing code writes data through submit_bh() and as a result only
> buffer dirty bits are cleared but page dirty bits stay set. Later when
> the filesystem is frozen, writeback code comes, tries to write
> supposedly dirty pages and the warning triggers. Fix the problem by
> calling sync_filesystem() once more after flushing the whole journal to
> clear stray page dirty bits.
> 
> [...]

Applied, thanks!

[1/1] ext4: Fix warnings when freezing filesystem with journaled data
      commit: 18b7f4107219ef12898b2ee77b8fb6de8887d1b7

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>