Date:   Fri, 17 Mar 2023 14:01:31 +0100
From:   Jan Kara <jack@suse.cz>
To:     Zhang Yi <yi.zhang@huaweicloud.com>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu,
        adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com,
        yukuai3@huawei.com
Subject: Re: [PATCH v4 2/2] ext4: add journal cycled recording support
Message-ID: <20230317130131.k2oabqxikk6p36en@quack3>
References: <20230317090926.4149399-1-yi.zhang@huaweicloud.com>
 <20230317090926.4149399-3-yi.zhang@huaweicloud.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230317090926.4149399-3-yi.zhang@huaweicloud.com>
Precedence: bulk

On Fri 17-03-23 17:09:26, Zhang Yi wrote:
> From: Zhang Yi <yi.zhang@huawei.com>
> 
> Always enable 'JBD2_CYCLE_RECORD' journal option on ext4, letting the
> jbd2 continue to record new journal transactions from the recovered
> journal head or the checkpointed transactions in the previous mount.
> 
> Signed-off-by: Zhang Yi <yi.zhang@huawei.com>

Looks good to me. Feel free to add:

Reviewed-by: Jan Kara <jack@suse.cz>

								Honza

> ---
>  fs/ext4/super.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 88f7b8a88c76..9b46adae241b 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -5691,6 +5691,11 @@ static void ext4_init_journal_params(struct super_block *sb, journal_t *journal)
>  		journal->j_flags |= JBD2_ABORT_ON_SYNCDATA_ERR;
>  	else
>  		journal->j_flags &= ~JBD2_ABORT_ON_SYNCDATA_ERR;
> +	/*
> +	 * Always enable journal cycle record option, letting the journal
> +	 * records log transactions continuously between each mount.
> +	 */
> +	journal->j_flags |= JBD2_CYCLE_RECORD;
>  	write_unlock(&journal->j_state_lock);
>  }
>  
> -- 
> 2.31.1
> 
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR