Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 120C6C74A5B for ; Fri, 17 Mar 2023 15:26:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229911AbjCQP0N (ORCPT ); Fri, 17 Mar 2023 11:26:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57960 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229959AbjCQP0J (ORCPT ); Fri, 17 Mar 2023 11:26:09 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1AF91C7FF for ; Fri, 17 Mar 2023 08:26:05 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 32HFPLH0000748 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 17 Mar 2023 11:25:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1679066724; bh=xeH+3p0rI2I0R5xWgIjV4GmlF5PUsheWzCK9zeEgr34=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=IHwsCeMrBR+r04+OmXrWYrZFc+cprczfvk0guXkuq3MYfAWXCbDUX9nikeDBI8sFL OsYKd5NzBKLkjxCy2f0LWnPoPdBr8geWt6R8fg84WOv561GX2yC++iUFIXL2wkny2Y nVZ9J+JSbhZ61OfKgXIyopXXY7BH+/LPtmlQ/thlRxnpkoYb6VXuKjMeKrUGtUugja 3kiOukccXmBkTZ2FkiL3A5VGZY2bvOIqPfgpvOn+zezB+gmSU0CEhk8qpfhagZDsPR 7qRX7kkYvA3Jffkqxk1aRH9Y7RW4b5Mu0GISR44RjdfoMakgpZIkPG3N/J6NyA9psD FyFiPlH/SDIgQ== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 8A9D615C33A7; Fri, 17 Mar 2023 11:25:21 -0400 (EDT) Date: Fri, 17 Mar 2023 11:25:21 -0400 From: "Theodore Ts'o" To: "wangjianjian (C)" Cc: Zhang Yi , linux-ext4@vger.kernel.org, adilger.kernel@dilger.ca, jack@suse.cz, yi.zhang@huawei.com, yukuai3@huawei.com Subject: Re: [PATCH v4 1/2] jbd2: continue to record log between each mount Message-ID: <20230317152521.GA3270589@mit.edu> References: <20230317090926.4149399-1-yi.zhang@huaweicloud.com> <20230317090926.4149399-2-yi.zhang@huaweicloud.com> <021bd760-a3f5-14fa-ca64-27882803abab@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <021bd760-a3f5-14fa-ca64-27882803abab@huawei.com> Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Mar 17, 2023 at 06:33:50PM +0800, wangjianjian (C) wrote: > Do we need update document/filesystems/ext4/journal.rst ? > > On 2023/3/17 17:09, Zhang Yi wrote: > > - __u32 s_padding[41]; > > + __be32 s_head; /* blocknr of head of log, only uptodate > > + * while the filesystem is clean */ > > +/* 0x005C */ > > + __u32 s_padding[40]; > > __be32 s_checksum; /* crc32c(superblock) */ Yes, please update journal.rst in the patch. - Ted