Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD9AC7619A for ; Sat, 18 Mar 2023 06:13:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229602AbjCRGNv (ORCPT ); Sat, 18 Mar 2023 02:13:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229533AbjCRGNt (ORCPT ); Sat, 18 Mar 2023 02:13:49 -0400 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A32884A1D1 for ; Fri, 17 Mar 2023 23:13:47 -0700 (PDT) Received: from canpemm500005.china.huawei.com (unknown [172.30.72.54]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4PdrH76tm2zHwYw; Sat, 18 Mar 2023 14:11:31 +0800 (CST) Received: from [10.174.176.34] (10.174.176.34) by canpemm500005.china.huawei.com (7.192.104.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sat, 18 Mar 2023 14:13:45 +0800 Subject: Re: [PATCH v4 1/2] jbd2: continue to record log between each mount To: Theodore Ts'o , "wangjianjian (C)" CC: Zhang Yi , , , , References: <20230317090926.4149399-1-yi.zhang@huaweicloud.com> <20230317090926.4149399-2-yi.zhang@huaweicloud.com> <021bd760-a3f5-14fa-ca64-27882803abab@huawei.com> <20230317152521.GA3270589@mit.edu> From: Zhang Yi Message-ID: <0d680f4b-92ed-6715-01c3-9f455772a186@huawei.com> Date: Sat, 18 Mar 2023 14:13:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20230317152521.GA3270589@mit.edu> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.174.176.34] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500005.china.huawei.com (7.192.104.229) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 2023/3/17 23:25, Theodore Ts'o wrote: > On Fri, Mar 17, 2023 at 06:33:50PM +0800, wangjianjian (C) wrote: >> Do we need update document/filesystems/ext4/journal.rst ? >> >> On 2023/3/17 17:09, Zhang Yi wrote: >>> - __u32 s_padding[41]; >>> + __be32 s_head; /* blocknr of head of log, only uptodate >>> + * while the filesystem is clean */ >>> +/* 0x005C */ >>> + __u32 s_padding[40]; >>> __be32 s_checksum; /* crc32c(superblock) */ > > Yes, please update journal.rst in the patch. > Yes, thanks for pointing this out. I will update it in journal.rst Thanks, Yi.