Date:   Sat, 18 Mar 2023 12:24:21 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Zhiqiang Liu <liuzhiqiang26@huawei.com>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>,
        adilger@whamcloud.com, Jan Kara <jack@suse.cz>,
        linfeilong <linfeilong@huawei.com>,
        wuguanghao <wuguanghao3@huawei.com>,
        zhanchengbin <zhanchengbin1@huawei.com>, libaokun1@huawei.com
Subject: Re: [PATCH] tune2fs: check whether dev is mounted or in use before
 setting
Message-ID: <20230318162421.GB11916@mit.edu>
References: <8babc8eb-1713-91c9-1efa-496909340a6f@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8babc8eb-1713-91c9-1efa-496909340a6f@huawei.com>
Precedence: bulk

On Sat, Mar 18, 2023 at 11:36:03AM +0800, Zhiqiang Liu wrote:
> From: Zhiqiang Liu <liuzhiqiang26@huawei.com>
> 
> tune2fs is used to adjust various tunable filesystem pars, which
> may conflict with kernel operations. So we should check whether
> device is mounted or in use at the begin similar to e2fsck and mke2fs.
> 
> Of course, we can ignore this check if -f is set.

Tune2fs is designed to work on mounted file systems.  There are
individual checks for those changes which can not be safely done on
mounted file systems, but most changes are safe to do on mounted file
systems.

Cheers,

					- Ted