Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp7675406rwl; Thu, 23 Mar 2023 07:23:19 -0700 (PDT) X-Google-Smtp-Source: AK7set+WihuTqln3Uq3Bm5CbQzQNUXcOYK/VcsnG7YaVhPU8K2nIJFZAQPLvTdToMG10SRRqESzA X-Received: by 2002:a17:903:183:b0:19c:cf89:b7ee with SMTP id z3-20020a170903018300b0019ccf89b7eemr6886977plg.69.1679581399099; Thu, 23 Mar 2023 07:23:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679581399; cv=none; d=google.com; s=arc-20160816; b=RWM0rD9ZkXTtBdYouxjA2we6GjaMe/dHFHIw+NlVWnIjgbiuVRbvxMrNn4O7Osa6gD LvHHoHv2UC51gykZypve/pVpiC+lEUifPp/8TaPmx+udgzeaxnqGwSotI2+UqkqjNvja 9DqbggDBGAxQ5+mobKBqD7geB5AHBGVulHsYs+r7hSVRBxt73f4gV4cywXr041kfakAK 0kk2F7lOoF4RPkDE4SLVkvm/BwgDMdXiGMMButxC7r+Li8n6TNN+kT0Ief3QmCH/RWeH 17Vw8KjQVmtH73JMhITiHvEAM/ape12uQhI4Pp5T6lKDsEig8dfPHgyGpjDClaAze/KS 9bAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=Lie5CtaiQbNIDt1S3TRfnx3qWKLuVWEezgIsumJ4veo=; b=uj137Dzi5XdhyCsaozMHoaNb4yrXLycoC9oMWNSwAqBA1SdllgG56zmZEwQerz2x1D pAwrdwv03KDCl5ioal3dLhDGNmptk2KTifS9dz3P2NFg0OJQ1xY2hYODbKOpx69A9YLF SUayLw1H9ftifEidnTgHyZ65OLV4Cgx5Z/vqC2dPolw9XAxsTGCEVd14XwtChXTlzeoZ 1XrkOxbt1iyrMbivw6c+nH0e9mX4zKLP0UjRvoCzJWloxqQ+CjgS2TkkgKUUN4BDFt+O rWRBe2t7G/kN9hYR5OgERMmelnpSg9Zb+59Ecrb50YiuZ6z6vgjUpozPjdq0KcLtIscj jAzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Yu8y5BmE; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b22-20020a170902d89600b001a1b5e2deb0si15570065plz.334.2023.03.23.07.23.05; Thu, 23 Mar 2023 07:23:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=Yu8y5BmE; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229917AbjCWOVr (ORCPT + 99 others); Thu, 23 Mar 2023 10:21:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230455AbjCWOVb (ORCPT ); Thu, 23 Mar 2023 10:21:31 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98D855B9D for ; Thu, 23 Mar 2023 07:21:30 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 32NELHju003275 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 23 Mar 2023 10:21:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1679581278; bh=Lie5CtaiQbNIDt1S3TRfnx3qWKLuVWEezgIsumJ4veo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Yu8y5BmEZQ6dKOkADZsggQzwLw+MvxjSIrkTK1GYoyYEvz9dCjZRcJiBA75EDZ9Bl vTsOqm36128cMMIgcRal42BcNZ0/SoC/f3GytJ/pox4lATwKRuTJf9CfD/Y5FntqlU OFSyteMeXLTef6RWl1LV7l5kMGcBPCgd0p7KT4BEE6X5lQO30f68mqWb3xrSRWHc54 /+tOuJ46xr5aAbcTFSoCC7oNv7Trnj58ORhGK6wIGRLsKr+f086XlSQ/JQLZP/Bj0N P+nE7b0BwVXQbB3F5OEjp/tid8WKQ2KSb8j2ddqFNfFdJbv4NzQ2dbrL7xtr3SbJGI SNLF5M9W2nUzw== Received: by cwcc.thunk.org (Postfix, from userid 15806) id 1689E15C4279; Thu, 23 Mar 2023 10:21:17 -0400 (EDT) Date: Thu, 23 Mar 2023 10:21:17 -0400 From: "Theodore Ts'o" To: Jan Kara Cc: Eric Biggers , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: Fix warnings when freezing filesystem with journaled data Message-ID: <20230323142117.GB136146@mit.edu> References: <20230308142528.12384-1-jack@suse.cz> <20230319183617.GA896@sol.localdomain> <20230321120653.j5fpyqk4iat6wrvu@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230321120653.j5fpyqk4iat6wrvu@quack3> X-Spam-Status: No, score=-2.1 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Jan, have you had a chance to look into finding a fixup to the problem that Eric identified? I'm not sure how I had missed this in my testing as well. :-/ If fixing this is going to take a while, I can drop this patch for now, especially since you've pointed out that the warning is a false positive. Thanks, - Ted