Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1485325rwl; Fri, 24 Mar 2023 11:06:15 -0700 (PDT) X-Google-Smtp-Source: AK7set8RX/aDV0k9fHnyY3lC+E1mr9cEVhDERALfqT3da/ufEoab6uWX7865luM1f1g5o5n90ISc X-Received: by 2002:a05:6a20:7924:b0:da:17b4:461a with SMTP id b36-20020a056a20792400b000da17b4461amr3583063pzg.32.1679681175506; Fri, 24 Mar 2023 11:06:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679681175; cv=none; d=google.com; s=arc-20160816; b=aGC8T+HWAli/pegRuDCaUSDBZXRS1QAedBvhdMZXedKyCZnhACi5hbinqbvN6ykUQa veGxLemTX7CLc6dvryO9cZyaKtcPwjpYqSshYNRez9QvIlBHfRCqQ14+D1tVbzYEOFe/ DxEANAJlPtqUfvnLAP+0RrAjH+b5P35ckdURNqHb5rb8FP/NBMgDCu6HADZEzC8amcCk H/inPeO+thR04RbzQbfSxXBUGVcZ3pvj5FHW7pr4ULih7jxeg0LCyp2edH2TgYRNBo07 Npm+VUHbDsuMEJy3+g5mFWX4BcGD+4iIe+C4e4fulJC3SlFyp4bb7Vd+SEOGZI5DE1gH Pxag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=B6M8HuoWV6vZq+HMi8zcrk8fjpiDsrISnaLF7YRAHOY=; b=R+UYDwP2U2eJ1zxEE91mR0lnT3g3YoAm6o9+XQ65322TRiK7Xtp/bKyH1sjmx4pbiK uj+6cKnxwejt1K+mTVFxfmSeIKGLAL5jQCNuX6lSoN3oqelMObZwgFivsXSWZ5Md1XbS dvupj5CmtLJ0x87YPjCXV8OVWDJAoMCZXuG/xXaDnp+NIeT3CNRyWlvhx3CnTjXxmZzF /jw39d1FhcgKnR8n7lyqYEoN+A4H5PucZl8Iqtpg4IBScd0FZq3kqLt/4Z1dq19nDsPA LHQFzQ1y5DbsZJAXx/fOmkML0UOCtUGwI5WFXJSbC8aCFKkRPMXCT3j8z6Nl/4mGjhfA LKnQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=KvL9qXX6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x5-20020a654145000000b0050f767a0265si13711088pgp.531.2023.03.24.11.06.02; Fri, 24 Mar 2023 11:06:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=KvL9qXX6; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232428AbjCXSD6 (ORCPT + 99 others); Fri, 24 Mar 2023 14:03:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232268AbjCXSC1 (ORCPT ); Fri, 24 Mar 2023 14:02:27 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 51C2DEC52; Fri, 24 Mar 2023 11:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=B6M8HuoWV6vZq+HMi8zcrk8fjpiDsrISnaLF7YRAHOY=; b=KvL9qXX6w7RiaracFLnGlfezyO YFGcVYwxZUeQJee0ZL/tcTMh2Lj6U1hftWLJjgkyQIJd5ORdxDgjB10rp0C7EocV8mcDZuU0Pe9A1 q6lGqGWsB3/oXYcx9B+T2w+AkG6dIR6e5Onh6CssNaC06+mn3WTnIg+feeXKtCOPH5iaFayJ0VnYd yjMPasR7ugNpnGqWRu4rJ1epLGXRaNp4smI810C68/IFBf2P6PzPuXh5rgmjv1LKw+M6y9xYlSFr6 LFGTSBPjnruH/7bzoRVRPQUUPK9/a/CfPsoTPi6mOIpSV1GBVgJc0InZfu7JMUpTHWh837YDjW+hT cxo9Da7g==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pfljO-0057c3-Ki; Fri, 24 Mar 2023 18:01:38 +0000 From: "Matthew Wilcox (Oracle)" To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: "Matthew Wilcox (Oracle)" , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2 28/29] ext4: Convert pagecache_read() to use a folio Date: Fri, 24 Mar 2023 18:01:28 +0000 Message-Id: <20230324180129.1220691-29-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230324180129.1220691-1-willy@infradead.org> References: <20230324180129.1220691-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Use the folio API and support folios of arbitrary sizes. Signed-off-by: Matthew Wilcox (Oracle) --- fs/ext4/verity.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c index e4da1704438e..afe847c967a4 100644 --- a/fs/ext4/verity.c +++ b/fs/ext4/verity.c @@ -42,18 +42,16 @@ static int pagecache_read(struct inode *inode, void *buf, size_t count, loff_t pos) { while (count) { - size_t n = min_t(size_t, count, - PAGE_SIZE - offset_in_page(pos)); - struct page *page; + struct folio *folio; + size_t n; - page = read_mapping_page(inode->i_mapping, pos >> PAGE_SHIFT, + folio = read_mapping_folio(inode->i_mapping, pos >> PAGE_SHIFT, NULL); - if (IS_ERR(page)) - return PTR_ERR(page); - - memcpy_from_page(buf, page, offset_in_page(pos), n); + if (IS_ERR(folio)) + return PTR_ERR(folio); - put_page(page); + n = memcpy_from_file_folio(buf, folio, pos, count); + folio_put(folio); buf += n; pos += n; -- 2.39.2