Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1485744rwl; Fri, 24 Mar 2023 11:06:33 -0700 (PDT) X-Google-Smtp-Source: AK7set+pNnjvypO9untt+2k6ZT8/KrFrOiQyloQQFecVe226jCNYsz1J2hRpekEJg88vP2V1s4vO X-Received: by 2002:a05:6a20:bb1a:b0:d4:298b:8b8e with SMTP id fc26-20020a056a20bb1a00b000d4298b8b8emr3590903pzb.33.1679681192886; Fri, 24 Mar 2023 11:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679681192; cv=none; d=google.com; s=arc-20160816; b=H7taWYsn+aQPk9/gKuk5ZFMJ1HR20eCWkK30H3ajWn85aDXaQBoxLvetbgox1YbAh0 EF68KeGp8UVd9j2SIPdtZdwlve2LohCSHa+Nn57VvP/tjeJNCCQHfy+d/078oCCeZJZk i66MLw39cmQq27MT0LhylQyxsQpDE3O2H+EjrR/CwhuDC+2AmPKjAdIpD8MCxsC/WFQz pvCq3fgK/MJEM2LxX+RHNhu3yOC4WrlpDXYzcb+LSwFhwIcRoGGlkEIzBMAMPQya80b/ m5pGgVng2YsvNwAf5dTftEQLru5XpsrndeocY674+3Tu5CbFgYHwUCgLuLh+s75L8cIN ZThg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7JmN+9SsTrOVuR3U9s6cPTX78SVj5kDXNdVOIgSxghc=; b=SHcyT1Q5/acqybImkNSXtUO2fmJBk2CTHoaay4RpZ176rhuEMsZ8Xs9MLg/uTL34fL 03fXysIT6CeyCKlo3AyNr+vE9ULVQPr/m6EqH9IwvRjivKfCq1UsW2MxOcpMVHduq88n AnsGinM14kzMeb1cAZo+q0Zya6453B6uzzelg7kfNy2zX0VTxd/rnTCPa65R9lnPsgrq m0DfaspG374ZfQ37z68495kwvMuanA/PkJ/Y0ILcc8YQR0mHcwa+VPRKwSzaEEJ8U/uP svAf28AG+UaiO+p7e7MpDLkGB368dOInqq55fjj+m+myV8/M3F6aenTF6ZDAbnot6ArM rqew== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CSUt6XsX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h71-20020a63834a000000b0050f975790e1si6632329pge.168.2023.03.24.11.06.20; Fri, 24 Mar 2023 11:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=CSUt6XsX; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232268AbjCXSEB (ORCPT + 99 others); Fri, 24 Mar 2023 14:04:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231825AbjCXSC1 (ORCPT ); Fri, 24 Mar 2023 14:02:27 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6624F1CF7E; Fri, 24 Mar 2023 11:02:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=Content-Transfer-Encoding:MIME-Version: References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To: Content-Type:Content-ID:Content-Description; bh=7JmN+9SsTrOVuR3U9s6cPTX78SVj5kDXNdVOIgSxghc=; b=CSUt6XsXbzHmp6n7xQY5Ige94+ aAShX/2DOcob2VEvxd4EST95lqZkJCAGvs/k1LrtN8X3tKTeITaqiBZHtTWXQLl2n60leIsiD3ljh hpdw9vhi1GqFFcvD0qtfQvr11hmj6LSICYfhKhecAF/5e1o6BBU8rzkZv6uZHdYmb0TcTowW9mjkJ JriP4kCaoPKL4PiITBYc4HSjVCFlBwuxU6aj27dK1DgYHmxnjeH6G02EyJMM+qybqL6JrfT4Hpr+I oXRutivS9HP10H+OCTB1YWC6f7s9WK3wctymBsWde3Kom5XmsnH/MOrQ8gnzp/UquTIgv5/6Dw6Yo tab3P41Q==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pfljO-0057cD-Qm; Fri, 24 Mar 2023 18:01:38 +0000 From: "Matthew Wilcox (Oracle)" To: tytso@mit.edu, adilger.kernel@dilger.ca Cc: "Matthew Wilcox (Oracle)" , linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [PATCH v2 29/29] ext4: Use a folio in ext4_read_merkle_tree_page Date: Fri, 24 Mar 2023 18:01:29 +0000 Message-Id: <20230324180129.1220691-30-willy@infradead.org> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20230324180129.1220691-1-willy@infradead.org> References: <20230324180129.1220691-1-willy@infradead.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org This is an implementation of fsverity_operations read_merkle_tree_page, so it must still return the precise page asked for, but we can use the folio API to reduce the number of conversions between folios & pages. Signed-off-by: Matthew Wilcox (Oracle) --- fs/ext4/verity.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/ext4/verity.c b/fs/ext4/verity.c index afe847c967a4..3b01247066dd 100644 --- a/fs/ext4/verity.c +++ b/fs/ext4/verity.c @@ -361,21 +361,21 @@ static struct page *ext4_read_merkle_tree_page(struct inode *inode, pgoff_t index, unsigned long num_ra_pages) { - struct page *page; + struct folio *folio; index += ext4_verity_metadata_pos(inode) >> PAGE_SHIFT; - page = find_get_page_flags(inode->i_mapping, index, FGP_ACCESSED); - if (!page || !PageUptodate(page)) { + folio = __filemap_get_folio(inode->i_mapping, index, FGP_ACCESSED, 0); + if (!folio || !folio_test_uptodate(folio)) { DEFINE_READAHEAD(ractl, NULL, NULL, inode->i_mapping, index); - if (page) - put_page(page); + if (folio) + folio_put(folio); else if (num_ra_pages > 1) page_cache_ra_unbounded(&ractl, num_ra_pages, 0); - page = read_mapping_page(inode->i_mapping, index, NULL); + folio = read_mapping_folio(inode->i_mapping, index, NULL); } - return page; + return folio_file_page(folio, index); } static int ext4_write_merkle_tree_block(struct inode *inode, const void *buf, -- 2.39.2