Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp1769797rwl; Fri, 24 Mar 2023 15:31:03 -0700 (PDT) X-Google-Smtp-Source: AKy350ZTlmLPuT4Xewg7TrNS9hZoljhKRsU0kfYfy7wLDic9ZVPmhQva0ywBzYRL2/s90YP3Tu92 X-Received: by 2002:a17:902:e5c3:b0:1a1:98a9:406f with SMTP id u3-20020a170902e5c300b001a198a9406fmr4969685plf.67.1679697063368; Fri, 24 Mar 2023 15:31:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679697063; cv=none; d=google.com; s=arc-20160816; b=eL9envf884Ef+NR1fu+2+TG09NOZogml1iTj/wHbZEFRiivyKE3ToKPdGpM45XMEKv qQCgZ5mYomHNaZ0RAi8NJYPXhoMiixCq8oN4R+uqHOpF40Cz95PCYhh1CZTJvGEQexbR eSBNumZGT0iiuKNcsv3YbvxN2liBxo4gPTkCJ6SpcV9/KkK7wvArwaswZA2ocCSfPX5B 53MMVsCSDORt1nTly4Bryj527ks9Gv8tELLEgelSTs8rXuEpK8p3T2/9hFstszLR7R6U cdGN0GNUpOFDLiK3xFqe+iW6+9BdV1+LgTwvhisq3AEU0n09TLBeBx1L9znoKqbc2AJG usOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=rxOsj9rAE7+vjDc83b7VeVp23H3gUFhrSuYlirliyVs=; b=deOYZtwhlazk+J+wgFzNQt9qnjwnbPn13dAaYzBHi+Ht2PSD6yE2UDwEZBPiFZwR4T FNeM1d+k2FYIhZ/4c72YCPNV9jIoHuxL2oaHNIOoeclXNCS0cooW/2BCDP9lO+q7XiFm lplWqlc/TEUVse/qlxhDU08AqmgvGOq64L0g4a3tmo8NWLqmuXF4Q0bkpRWK9qtVBlOC mmiOoGaOw0OO5b9c0zJ554Ed9LNXaHrahGLpqATa4Gvegmq3tRqf1X1Kcxc0tHdnAZ7M xcfsXIxA7FavFxqeE85d1jsGHa7fgOjqfIGB2ExWB7lyWLMgLLtpxJL+ynu1W20HgyoA iJ+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oub1ERdZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u18-20020a170902e5d200b001a1f392b82esi7886530plf.512.2023.03.24.15.30.41; Fri, 24 Mar 2023 15:31:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=oub1ERdZ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231569AbjCXW35 (ORCPT + 99 others); Fri, 24 Mar 2023 18:29:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231572AbjCXW34 (ORCPT ); Fri, 24 Mar 2023 18:29:56 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A70DC9030; Fri, 24 Mar 2023 15:29:55 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5F2F8B8263C; Fri, 24 Mar 2023 22:29:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E6997C433EF; Fri, 24 Mar 2023 22:29:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679696993; bh=AAbNs8yXqUH1VLSX1EbrMvKD4w9xN6cND5bc44EXnNs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oub1ERdZpGa3VXfqNJirfBHoExS41xguPkv2XJ0Yn6CIYq2Uj0hWsuDUfxH4zLOyl TuPfAJRDy1U+yYcDKhvEQurhpP0MALiu8x/6PLJJ5q6Gu3SQqvQOe7kd7vtZ1SuCoV eT0rp5WEz7VHugRV8OFFXrt7yI7sIUsaJS01ZuFOlMcb6vA6qBdYXew+TfVSfgXDzf vR0jrgsgvKNNI2CCXFKeyTMw4DCBAzkeZU1v8DhD28tlABtLeuEqCzocGXI4kLHMWj NwBk3heZKxnNTrRzR7JPyVo2Hop0Hf5sZOjKjbyjdcCyYefBcTSFE2QL5YMa+Ctdef H7Q8Td4itDxOw== Date: Fri, 24 Mar 2023 15:29:51 -0700 From: Eric Biggers To: "Matthew Wilcox (Oracle)" Cc: tytso@mit.edu, adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 23/29] ext4: Convert ext4_mpage_readpages() to work on folios Message-ID: <20230324222951.GA5083@sol.localdomain> References: <20230324180129.1220691-1-willy@infradead.org> <20230324180129.1220691-24-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230324180129.1220691-24-willy@infradead.org> X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Fri, Mar 24, 2023 at 06:01:23PM +0000, Matthew Wilcox (Oracle) wrote: > if (first_hole != blocks_per_page) { > - zero_user_segment(page, first_hole << blkbits, > - PAGE_SIZE); > + folio_zero_segment(folio, first_hole << blkbits, > + folio_size(folio)); > if (first_hole == 0) { > - if (ext4_need_verity(inode, page->index) && > - !fsverity_verify_page(page)) > + if (ext4_need_verity(inode, folio->index) && > + !fsverity_verify_page(&folio->page)) > goto set_error_page; This can use fsverity_verify_folio(). - Eric