Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230324092907.1341457-1-cccheng@synology.com> <20230327092914.mzizhh52izbvjhhv@quack3>
In-Reply-To: <20230327092914.mzizhh52izbvjhhv@quack3>
From:   Chung-Chiang Cheng <shepjeng@gmail.com>
Date:   Mon, 27 Mar 2023 18:28:55 +0800
Message-ID: <CAHuHWt=LaNBwNy-1RY2-OZ4zGKEgTBfZZGWoQJSjL3ADbRRCoQ@mail.gmail.com>
Subject: Re: [PATCH] ext4: defer updating i_disksize until endio
To:     Jan Kara <jack@suse.cz>
Cc:     Chung-Chiang Cheng <cccheng@synology.com>,
        linux-ext4@vger.kernel.org, tytso@mit.edu,
        adilger.kernel@dilger.ca, yi.zhang@huawei.com, kernel@cccheng.net,
        Robbie Ko <robbieko@synology.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Mar 27, 2023 at 5:29=E2=80=AFPM Jan Kara <jack@suse.cz> wrote:
>
> As Zhang Yi already noted in his review, this is expected at least with
> data=3Dwriteback mount option. With data=3Dordered this should not happen
> though as the commit of the transaction with i_disksize update will wait
> for page writeback to complete (this is exactly the reason why data=3Dord=
ered
> exists after all). Are you able to observe this problem with data=3Dorder=
ed
> mount option?
>
>                                                                 Honza

It's a pity that this issue also occurs with data=3Dordered due to delayed
allocation being enabled by default. If delayed allocation were disabled,
it would not be as easy to reproduce.

This is because if data is written to the end of a file and the block is
allocated, the new i_disksize will be immediately committed to the journal
at ext4_da_write_end(), but the writeback procedure is not yet triggered.
By default, ext4 commits the journal every 5 seconds, but a dirty page may
not be written back until 30 seconds later. This is not a short time window=
,
and any improper shutdown during this time may lead to the issue :(

Thanks.
C.C.Cheng