Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 29 Mar 2023 17:05:45 -0700
From:   Christoph Hellwig <hch@infradead.org>
To:     Jan Kara <jack@suse.cz>
Cc:     Ted Tso <tytso@mit.edu>, linux-ext4@vger.kernel.org
Subject: Re: [PATCH 06/13] ext4: Drop special handling of journalled data
 from ext4_sync_file()
Message-ID: <ZCTSWQk+8jxQckXG@infradead.org>
References: <20230329125740.4127-1-jack@suse.cz>
 <20230329154950.19720-6-jack@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230329154950.19720-6-jack@suse.cz>
Precedence: bulk

On Wed, Mar 29, 2023 at 05:49:37PM +0200, Jan Kara wrote:
>  	/*
> -	 * data=writeback,ordered:
>  	 *  The caller's filemap_fdatawrite()/wait will sync the data.
>  	 *  Metadata is in the journal, we wait for proper transaction to
>  	 *  commit here.

Nit: without the list, the two space indent looks a bit weird here.

>  	if (!sbi->s_journal)
>  		ret = ext4_fsync_nojournal(inode, datasync, &needs_barrier);
> -	else if (ext4_should_journal_data(inode))
> -		ret = ext4_force_commit(inode->i_sb);
>  	else
>  		ret = ext4_fsync_journal(inode, datasync, &needs_barrier);

Also if there is not journale the above comment doesn't make much sense.
But I'm really not sure the comment adds any value to start with, so
maybe just drop it entirely?