Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 30 Mar 2023 10:21:46 +0200
From:   Jan Kara <jack@suse.cz>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     Jan Kara <jack@suse.cz>, Ted Tso <tytso@mit.edu>,
        linux-ext4@vger.kernel.org
Subject: Re: [PATCH 06/13] ext4: Drop special handling of journalled data
 from ext4_sync_file()
Message-ID: <20230330082146.muy4j4ehf3l7w3xi@quack3>
References: <20230329125740.4127-1-jack@suse.cz>
 <20230329154950.19720-6-jack@suse.cz>
 <ZCTSWQk+8jxQckXG@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ZCTSWQk+8jxQckXG@infradead.org>
Precedence: bulk

On Wed 29-03-23 17:05:45, Christoph Hellwig wrote:
> On Wed, Mar 29, 2023 at 05:49:37PM +0200, Jan Kara wrote:
> >  	/*
> > -	 * data=writeback,ordered:
> >  	 *  The caller's filemap_fdatawrite()/wait will sync the data.
> >  	 *  Metadata is in the journal, we wait for proper transaction to
> >  	 *  commit here.
> 
> Nit: without the list, the two space indent looks a bit weird here.
> 
> >  	if (!sbi->s_journal)
> >  		ret = ext4_fsync_nojournal(inode, datasync, &needs_barrier);
> > -	else if (ext4_should_journal_data(inode))
> > -		ret = ext4_force_commit(inode->i_sb);
> >  	else
> >  		ret = ext4_fsync_journal(inode, datasync, &needs_barrier);
> 
> Also if there is not journale the above comment doesn't make much sense.
> But I'm really not sure the comment adds any value to start with, so
> maybe just drop it entirely?

Hum, right. I'll just drop the whole comment. Thanks for the suggestion.

								Honza


-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR