Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp6159564rwl; Tue, 4 Apr 2023 08:36:27 -0700 (PDT) X-Google-Smtp-Source: AKy350ZCtrs0F7FOGVXy/sgZDEGe1tiLHG3Q6N+qVrXoF2RbTeNT5ywJjos/MX5IBBYNTh/gV808 X-Received: by 2002:a05:6a20:4b02:b0:db:aae4:7b41 with SMTP id fp2-20020a056a204b0200b000dbaae47b41mr2179194pzb.21.1680622587708; Tue, 04 Apr 2023 08:36:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680622587; cv=none; d=google.com; s=arc-20160816; b=TXsLMqdQHnsLU9yNgA5DYOzp9FQgoRZefA6w4LWjgniThW6vK4GZAZ68kMTow9ozGr l6U1bdGPEQ9le7+6MIa0RBonuOJhjs22b9/4sV8qveVjeKWEFycQNrwz4MexY42Pomnw qWx/W2vfm0/GcYFz/syiC+ZaELSx9lbbRXDAxIWRGFfDyjOsDgcT/qpGsm4oLBXT4UGE 8gMnpbh64YU+4lFlCDQxmlZwiifXMjvQPKj5f9/yXRiprJ+steBanqr+4Ni+I+HQWLQc DQc6eByNJylrBivD+9QP5xzfGwtZzDq7DKXSMHfqpGiGENsHvnmCg1WTyZ9r/Cswd8EE MO8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=oRUY6/nVUdkJWa+BgfeeaayCjIWt7sUTbaMHlXagjNw=; b=m0rfBcGZlTdodyRy1VbYsueGlhuJaBDQdkOUhpSnLqMlyopsg0Od844FKB2F4HXac4 XQvBFBXwX4E5ReSkdeqqCxSA7iU+qx2DB4iKkuUC+AEx7LP9njdmsnRvv1x//abnBgC9 bthDSyXyXWTnQX5zLU6FerOTO3xELC59tC8MhIZkZPxI48SBMta9eH6Q+zevmqhxoqP1 /qEaCqlCehYUkZP21W4VkDixTIWZ2wYwpzBlKCAsFodEOxwSmI9tZ3HBKdZDSCtnthZR R6aDTirz/CphBN4Pt0EueZ41P6Nf5Jie8DgAOdiGC0vkRedHPkNG+00fT2kYsieQ1wcA h7wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Fn5hZQra; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id z2-20020aa79902000000b0062a450c3296si1599547pff.75.2023.04.04.08.35.33; Tue, 04 Apr 2023 08:36:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Fn5hZQra; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234931AbjDDPau (ORCPT + 99 others); Tue, 4 Apr 2023 11:30:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48002 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229691AbjDDPat (ORCPT ); Tue, 4 Apr 2023 11:30:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8A4B8449E; Tue, 4 Apr 2023 08:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oRUY6/nVUdkJWa+BgfeeaayCjIWt7sUTbaMHlXagjNw=; b=Fn5hZQrai6OxRnc53wDWJvsQUi l0f2jY/0e+u5hzy8V4qA0uX6eNIA0HL+/ThjvZ+58OfHp5yJqwS4UwWtJa85+FoQv1YOF18PQ8y/e fZlpCpeR10Vlao2xf/ZiIbKLawae3/lvFHmhVGCbU5EseY8BqD2Zq9XQmLqu1Rs3Ie8J+zOpNJhqg WOPGvV+nuedhEDvyiMY4PKQZIb21ECVPvSGrC0nkv5nmqQuhLqlykdFWXGNzzFth3lMtIfRXD4Co3 i32ooWz4rlCAa8EN+liRSIfzaYutkEpt2RTf3KItD2VFGXXaziebwy1oggfRtL771dhH2RwYQSCtU E2Ik6G2g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pjicG-0020iL-1q; Tue, 04 Apr 2023 15:30:36 +0000 Date: Tue, 4 Apr 2023 08:30:36 -0700 From: Christoph Hellwig To: Andrey Albershteyn Cc: djwong@kernel.org, dchinner@redhat.com, ebiggers@kernel.org, hch@infradead.org, linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, rpeterso@redhat.com, agruenba@redhat.com, xiang@kernel.org, chao@kernel.org, damien.lemoal@opensource.wdc.com, jth@kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com Subject: Re: [PATCH v2 05/23] fsverity: make fsverity_verify_folio() accept folio's offset and size Message-ID: References: <20230404145319.2057051-1-aalbersh@redhat.com> <20230404145319.2057051-6-aalbersh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404145319.2057051-6-aalbersh@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 04, 2023 at 04:53:01PM +0200, Andrey Albershteyn wrote: > Not the whole folio always need to be verified by fs-verity (e.g. > with 1k blocks). Use passed folio's offset and size. Why can't those callers just call fsverity_verify_blocks directly?