Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 05 Apr 2023 19:58:40 -0700
From:   Kees Cook <kees@kernel.org>
To:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Kees Cook <keescook@chromium.org>,
        Cezary Rojewski <cezary.rojewski@intel.com>,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
        Theodore Ts'o <tytso@mit.edu>, Jan Kara <jack@suse.com>,
        "Rafael J. Wysocki" <rafael@kernel.org>
Subject: =?US-ASCII?Q?Re=3A_=5BPATCH_v2_0/3=5D_lib/string=5Fhelpers_et?= =?US-ASCII?Q?_al=2E=3A_Change_return_value_of_strreplace=28=29?=
User-Agent: K-9 Mail for Android
In-Reply-To: <ZC2H8ODMwoO5hzZG@smile.fi.intel.com>
References: <20230323123704.37983-1-andriy.shevchenko@linux.intel.com> <ZC1454AwRUNFTbIW@smile.fi.intel.com> <2023040523-unworthy-uncured-1eab@gregkh> <ZC2H8ODMwoO5hzZG@smile.fi.intel.com>
Message-ID: <47D8878A-1108-4AC3-BF7F-507F90F6970A@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On April 5, 2023 7:38:40 AM PDT, Andy Shevchenko <andriy=2Eshevchenko@linux=
=2Eintel=2Ecom> wrote:
>On Wed, Apr 05, 2023 at 04:24:42PM +0200, Greg Kroah-Hartman wrote:
>> On Wed, Apr 05, 2023 at 04:34:31PM +0300, Andy Shevchenko wrote:
>> > On Thu, Mar 23, 2023 at 02:37:01PM +0200, Andy Shevchenko wrote:
>> > > It's more convenient to have strreplace() to return the pointer to
>> > >  the string itself=2E This will help users to make their code bette=
r=2E
>> > >=20
>> > > The patch 1 kills the only user of the returned value of strreplace=
(),
>> > > Patch 2 converts the return value of strreplace()=2E And patch 3 sh=
ows
>> > > how it may be useful=2E That said, the series can be routed via fs =
tree,
>> > > with or without the last patch=2E
>> >=20
>> > Since there are no comments, who can apply this (patches 1 and 2)?
>> > Greg, are you fine with the kobject change?
>>=20
>> Sure, want me to take them all through my driver-core tree?
>
>Fine by me! Dunno about others=2E Kees?

Yeah, that's cool by me=2E :)


--=20
Kees Cook