Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5025192rwl; Mon, 10 Apr 2023 22:27:50 -0700 (PDT) X-Google-Smtp-Source: AKy350YhojTvAu5mSwB/IYLWtcRpu/qkVpuwcpEVooDHw3Ovx13SxDSagn/0gAfiTtKwJFs85N8h X-Received: by 2002:a17:903:1107:b0:1a5:309e:d205 with SMTP id n7-20020a170903110700b001a5309ed205mr1906983plh.21.1681190870004; Mon, 10 Apr 2023 22:27:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681190869; cv=none; d=google.com; s=arc-20160816; b=mn9es4JyiUkKybYjbObV+biOCvys6Yp3g+bzGkErQVzTc+I3LazA5dW2vMzUk6R6pv Y2NnDZE10BndErmOx9ZotItqvRvXqnZSCpb4qN7WSKD1z1dpqMUk2kWpwAF/BDiqGO68 rdqwfhr30R/doUYVqhu9jSp6wNCwVrXL95bYqbA+GunPcjWpM3l9fYcOOZcj9gYVzPsS jP7HwHsaz71D0QZWMbwBhtwDRbpYgVN6qdUV2ZgGMb3q6Njjmb4HjaatEaSwhyBn7jGZ 8TTj3dRsFVMvOubzuDXDBbQGj3kVsKFPXcmWtJwvYlEtSS3gQ0fX1eogIqxRRn7axmjS ZwDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6nX5sI6EN+QIsWtAaq5RhWz/W4vuyCGzISy2tTv8b6w=; b=q4yImrQagjot8YTGgi6eTx89VOffb+6KZXTN5IBXszfkTsmJ9v8V53KJcCbhs/sVF8 TiU0GeD3pJK8Z705+qiDRp8Sigq71+v/x6egjatoJoB16uXzk82I0W3XzwyZ+b2xCbv0 M/4UtWj/1QsJdSAGoaAnjWGBJrnfbaxK0ZJm+r9i5fNzAjBIuiVKe9BvOmYPYIMhvHam 7ihuM7Q9mc8CkCqWVoVUW5HAGw2pJp/OsGh0IR3CgoJxB0ktrrCsHR1sVtuhgW0/VXQO FKFX0pAG4tPlmQ2f/NA6xuTLrORdDIJoAGUh3X92zR/wFfN+oWPWpcCmmVc1RZrU1w3j LVQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=k1nDyW9T; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w14-20020a170902e88e00b001a1894a141esi13869565plg.43.2023.04.10.22.27.36; Mon, 10 Apr 2023 22:27:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=k1nDyW9T; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjDKFT5 (ORCPT + 99 others); Tue, 11 Apr 2023 01:19:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229688AbjDKFT5 (ORCPT ); Tue, 11 Apr 2023 01:19:57 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AAF5EE7C; Mon, 10 Apr 2023 22:19:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=6nX5sI6EN+QIsWtAaq5RhWz/W4vuyCGzISy2tTv8b6w=; b=k1nDyW9ThWdwLT7pSWirEu8vAz 5gsYJWy42X4KvcpSpeCIEbOYds8a6VmdcdtnrFfTUZOMfEQkb0BOzhlbMIm5cunipw+jcMqtf6L/r FPpApigHLGsj0AbugbMiQtHKiTFGY9ozfe/zBscnPg1Mzgw7dPOExuqFoZe1d4/QjfAIxWMa+PTwM 0e/gNRrYWpCr+ICTg8kD6Z7Kzqr7DVQAQCnWLRdiGK4HSeKC67KTJGD8gscP39JkuZlIwihkF+6hw gY+QlKY1Wbp8V4K0W3LfRl2b/hiI8yJJDxRKMbrd7FtzqjIBqzmCFNIpdbdq70XMfufV+YB7upDdm vTfdPYZg==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pm6Py-00GReU-09; Tue, 11 Apr 2023 05:19:46 +0000 Date: Mon, 10 Apr 2023 22:19:46 -0700 From: Christoph Hellwig To: Andrey Albershteyn Cc: djwong@kernel.org, dchinner@redhat.com, ebiggers@kernel.org, hch@infradead.org, linux-xfs@vger.kernel.org, fsverity@lists.linux.dev, rpeterso@redhat.com, agruenba@redhat.com, xiang@kernel.org, chao@kernel.org, damien.lemoal@opensource.wdc.com, jth@kernel.org, linux-erofs@lists.ozlabs.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com Subject: Re: [PATCH v2 00/23] fs-verity support for XFS Message-ID: References: <20230404145319.2057051-1-aalbersh@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230404145319.2057051-1-aalbersh@redhat.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Dave is going to hate me for this, but.. I've been looking over some of the interfaces here, and I'm starting to very seriously questioning the design decisions of storing the fsverity hashes in xattrs. Yes, storing them beyond i_size in the file is a bit of a hack, but it allows to reuse a lot of the existing infrastructure, and much of fsverity is based around it. So storing them in an xattrs causes a lot of churn in the interface. And the XFS side with special casing xattr indices also seems not exactly nice.