Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5034924rwl; Mon, 10 Apr 2023 22:39:41 -0700 (PDT) X-Google-Smtp-Source: AKy350ZJj9rJd7cxZVBnHYMRmEv8qaWGYo7Em9SkhAuk7ww8apbzbii8nwhAShbm8WAUpR4UMZU8 X-Received: by 2002:a05:6402:348e:b0:504:7b24:7dff with SMTP id v14-20020a056402348e00b005047b247dffmr12075896edc.9.1681191580888; Mon, 10 Apr 2023 22:39:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681191580; cv=none; d=google.com; s=arc-20160816; b=W0Sd0IWXob4QxntQa/qt2KF17rsMXO7PHds2lD6WoQXSGjTbNNLgp6NyVMJ6PWuUJp uwdao//xP5FODQpG3hy3XVSl7N/AqepuaK76Hsn/z8UjwBXcT5U5gN/ubHjxH0KKN8e0 hAZfdSzqk4vZrA5dE5HmA7wfwePDglTSP6Oyy3uhgAaZFd7HO/iYPRGc6HGnesMESxOT Y5S1Xg/SFyU1wNg6YdEZI1jO7w0Ck9ya6XHcZn/U6UjvyLktrzIlTUHFnIaPy4DpmRKF vtjgOZYxW7oOOGrQ+5F0mlP0oRFttEegRBpZxDOvcQ1jdyyPXz2jxTxUjPsPLRFgPg7N 7HxA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=wdjx0PzS8xymLv6V2DZoByQwCNONkYBPrVTslqWkC1A=; b=Pd82uizeaFNdEx0Jv1cgXmlmWYQejHuRnNzvEPVD4ugDXFDES8KBWmoY0hI0r1KSZf ET7ptJjmme4Rqx3otumtGjudxgiizWrPRkShsR57UZtD5lamswpjjxdxG1O4l4wdVST8 rSnPqL0QwJRYvCh5I+S4HeCsZ3LKPY4zpGWb7i8lTcU6VsS9BULMinyKqaMoHiDl7LZB +SFJqm7hgA+q+kSZ8K9R0JEPPtW+HpZ0knloDccFqQ1YffIXg2qu1h4i92Yi/JY3GQ1/ Y9JSxFGJCiVjwdkz1lq2+KBCK/DLN6d7JArp3DyFNQefyjdOgSrlNIm9ffHpkfKOt9nI 6/Kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zAusoAFh; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id w6-20020aa7cb46000000b004e1db2eb805si10570103edt.494.2023.04.10.22.39.17; Mon, 10 Apr 2023 22:39:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=zAusoAFh; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229829AbjDKFio (ORCPT + 99 others); Tue, 11 Apr 2023 01:38:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbjDKFin (ORCPT ); Tue, 11 Apr 2023 01:38:43 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0DACC26AB; Mon, 10 Apr 2023 22:38:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wdjx0PzS8xymLv6V2DZoByQwCNONkYBPrVTslqWkC1A=; b=zAusoAFh2XMcpSwwXL3MEkMcu7 Xj1oSdkF/wpKDaVA9/ijVxJ3R2zTgfN5VRSQKn6+CrqM3Eh2Q7X3alR28o/5krCxZEjZYdWzzP0/r YbA+BQ8PdNq1+4l35cH2F6+7F0/Pj6DW/VmUQWXaEKRNupQOUOriwuguaWwZ/2DoIP5Bv4bY6/Ywg qI74eVnfuSSrwCb2pAdbN4PUQftLzlVzNnm4XND4ERebRG1BAMqtsjEn1vEyJuh7BydIjEFAgSExv BfOnzxa9My4ShATNT1ynIG8JWZ8GOSwLNVBxKwLxMVteB3NPIfEoPuYlJikt05r7FymlF/l/aSlus GaSLvs/g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pm6iE-00GU6N-2t; Tue, 11 Apr 2023 05:38:38 +0000 Date: Mon, 10 Apr 2023 22:38:38 -0700 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara , Christoph Hellwig , "Darrick J . Wong" , Ojaswin Mujoo Subject: Re: [RFCv2 8/8] ext2: Add direct-io trace points Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.5 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Tue, Apr 11, 2023 at 10:51:56AM +0530, Ritesh Harjani (IBM) wrote: > This patch adds the trace point to ext2 direct-io apis > in fs/ext2/file.c Wouldn't it make more sense to add this to iomap instead?