Received: by 2002:a05:6358:11c7:b0:104:8066:f915 with SMTP id i7csp5600160rwl; Tue, 11 Apr 2023 07:37:51 -0700 (PDT) X-Google-Smtp-Source: AKy350al29dXqJb3NBZ436MNQyDKVhfZaGAX+myUxL3czJ2FFGoR+7KogBDVaP3fmtib8aM4KGNY X-Received: by 2002:a17:906:5008:b0:94a:a6de:e43b with SMTP id s8-20020a170906500800b0094aa6dee43bmr2944136ejj.40.1681223871499; Tue, 11 Apr 2023 07:37:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681223871; cv=none; d=google.com; s=arc-20160816; b=MSLmpqaJTnu+cAJhwEkz2Ieq7LadKlc2FGvD68nbGed6/2Hjb1+WJRbo4x2281SqbR dTVF5b7ynT2zjrEotcWlUpcWoiz7ydx5KVVt4hK4Up41V2QXBBaAyVpp816CHlz2jjXp LSYEa7+9Bx6GkELO5x3DgECYgeb54Tc5cqMOpENce4sqrAbCd7eRXMzrsFo7LJClX17Q E2XxXEWjtl9RLTzaDeUEtgwxT6o9PbCSeqruJQofLoRkCZ3SYNLoRQXPdart+sd4dDKJ FndgddepY0N8ZfooOhYBmb9+ZzdcFiVd7R8b1mAdIe7WRm7QL0HxX+/JIb5cp/aVN3Pf PBUw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=LCDpy7Io/QiI62Ri5LyleA810zba43qSGPrdnSWs8kg=; b=O9bjMo33Ry/raBETRr3629SWCXLRCmL2B8JSNvRRTRDSrq3RA3dKIpBZrlQZkdH4bA pp0ll+ehGw54EgT9Gc/gUpSuqK4QenQMjbKG/Dn3RJbO46PZYUC3sDhRL2oyWpcQii7k gZ+eSt0rVHe8HTPX2z2skFMJDeFJ+APuvH2E3jI0rVIEGWQNVX5xoDL8a5v0viCAGQJI plIiD0HTMCys2Fsj5/F7MPoZS1lhVss1jdNmqjvJ+Qz3NJGme+U+KdhlmgGvpHATOAKv tT+ecJ7KL2fK2IzH9INPIJia9hO9CR5yMVls3j1uHswqgvtf8kanPoW2FFCFAVvFR/Ep qZCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IeN1E/1X"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u24-20020aa7d0d8000000b0050480f6caf9si7628635edo.62.2023.04.11.07.37.25; Tue, 11 Apr 2023 07:37:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b="IeN1E/1X"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229658AbjDKOeh (ORCPT + 99 others); Tue, 11 Apr 2023 10:34:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjDKOeg (ORCPT ); Tue, 11 Apr 2023 10:34:36 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4069010EF; Tue, 11 Apr 2023 07:34:35 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEF9A61F8E; Tue, 11 Apr 2023 14:34:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E95FC433EF; Tue, 11 Apr 2023 14:34:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681223674; bh=MY2Jh2ITaK90WSjyGrpw+XZfnUrc7i6nbRmq+ixgu40=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IeN1E/1X0dvMq0QlS96yiT76N/NHakRk0ac4VX/XbHJN96waYJMzH48pIvAxyVl1d susg/zQNz1gsMa5G9MKdOmBu19rVJ2tIn5wD7rDQ5HatAyDV3eNRTeORW2UXF1C2cX mVWueDavvFSLGe15SW8YPyllXmIqsHDwRXWI4ZCHYTOqyeGdevy8EbfgztvVvPh28w MyYhUrl8g/YuKNEray30HzKAgfK/NSn4LlxM9gVEDpxl8X1dSsbj4qolrZxePBfE03 Lm3da3rYvWU6uaithuRR9oswFKZjQ0f2kv/ScJ5qFPmgkZulhBsIZMvKbwgUM9XJKk iA4ilPw5HjUUQ== Date: Tue, 11 Apr 2023 07:34:33 -0700 From: "Darrick J. Wong" To: Christoph Hellwig Cc: "Ritesh Harjani (IBM)" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara , Ojaswin Mujoo Subject: Re: [RFCv2 8/8] ext2: Add direct-io trace points Message-ID: <20230411143433.GE360895@frogsfrogsfrogs> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-5.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Apr 10, 2023 at 10:38:38PM -0700, Christoph Hellwig wrote: > On Tue, Apr 11, 2023 at 10:51:56AM +0530, Ritesh Harjani (IBM) wrote: > > This patch adds the trace point to ext2 direct-io apis > > in fs/ext2/file.c > > Wouldn't it make more sense to add this to iomap instead? Yes please. :) --D