Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 12 Apr 2023 19:37:50 +0530
Message-Id: <87o7ntyz0p.fsf@doe.com>
From:   Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     "Darrick J. Wong" <djwong@kernel.org>,
        Christoph Hellwig <hch@infradead.org>,
        linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        Jan Kara <jack@suse.cz>, Ojaswin Mujoo <ojaswin@linux.ibm.com>
Subject: Re: [RFCv2 8/8] ext2: Add direct-io trace points
In-Reply-To: <ZDaZqL8eAw5qgecQ@infradead.org>
Precedence: bulk

Christoph Hellwig <hch@infradead.org> writes:

> On Tue, Apr 11, 2023 at 08:41:05PM +0530, Ritesh Harjani wrote:
>> Sure. Let me also add a trace event for iomap DIO as well in the next revision.
>> However I would like to keep ext2 dio trace point as is :)
>
> Am I confused, or does this patch only add new trace points anyway?

I meant to keep ext2 trace point as well. One of the reason for
that would be if someone wants to just enable all ext2 related tracing
logs, it would be easier.

$ trace-cmd -e ext2
$ trace-cmd report

But since iomap dio also doesn't have a tracepoint, I am looking to
add that in the next revision.

-ritesh