Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp2522098rwe; Sat, 15 Apr 2023 23:04:40 -0700 (PDT) X-Google-Smtp-Source: AKy350Z2xzjArnj7yDXByIhTeLXFHj1SJV2F8fd20HA/5kQdUdxm+R0I/JsyA2MmtODS05eZuJVd X-Received: by 2002:a17:902:fac3:b0:1a5:309e:d209 with SMTP id ld3-20020a170902fac300b001a5309ed209mr8508469plb.42.1681625080627; Sat, 15 Apr 2023 23:04:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681625080; cv=none; d=google.com; s=arc-20160816; b=AsVAOowHcKlPUQs97+s3P/ndxQIT+qrVgb5BQu1IjQLJP0mB8QIa61VPVNL+uFh89a NOIutdAzcmgo01iM6FB67/Bv5DrIYJG8qbfu00o6RsMLMiaH9CLwRFo32uN/H8B1ZdQ7 WPYfcvtTTdVAP3qTlOAogXW4ZZlYPgv3E5R6XyH9DbnHJe+iO1nqWzxmiqtZS/qYflkM hUAcu5zIxBpArZizsU6+0pnlf/zsTe+N+lJvF4bSbszKkapDAl4jEE1DaEuefu/ELBsy c4JrEk41RDeiKxZqfRejyXBgT57pb0s6wJkDdGGzcfouY+DCebK2gVkeVFi1Hgeg7O73 5hVw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=D1Ny97r9Y3cjcJeTg3thWBrN3BXrElakiqz0kq71xrA=; b=yqf6UC+3QnDrg3ZUYJ4m+Nrxi/J0itOUKyd16w41ieU+2hqoI4rmGeyXP3nD1y4lGO dJIIICGg3PsjrmCg8cd7cqfyXXOKZA92yIkHcY2mgBnT7MEghoemvfZgvYX52JLbKJ26 nTM6DReZLA9rN4OwPnJQpn+l0+HEm9L0SVC/y57s6G4/57bJo8T1yCaA/QIbNMEbZ3C9 BFMgEwdC8Q90XBZIpTpDhXgg5JVzSqCv94sPjuvX6XIQ4o6c9fzmcz5UTtFmpzcmw7eu KComU5LFjkhaivj0h5/vYENXtsMFS7M43OLdXPXyqtKZukpT4spXwQ4xlnkpxzBoGEPo 2kgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Necb7akl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x23-20020a170902821700b0019f33c0d583si7262025pln.315.2023.04.15.23.04.28; Sat, 15 Apr 2023 23:04:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=Necb7akl; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229827AbjDPF77 (ORCPT + 99 others); Sun, 16 Apr 2023 01:59:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjDPF76 (ORCPT ); Sun, 16 Apr 2023 01:59:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C44762681; Sat, 15 Apr 2023 22:59:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=D1Ny97r9Y3cjcJeTg3thWBrN3BXrElakiqz0kq71xrA=; b=Necb7aklV81Cw78Ub8q5Ctf1uv fALPm24TJjpAzrikDLpdZfrYQ7qNdPOcuiAwtnkCk0+5NSBGfVGOcTfFzfEH5nZ/4INYk5pbkFMOT QHYjXwjUIbuJSRXb2gTJvJGtZ4Kmos6UYnLI4OZrpxqeCux4uJ/Mw00U99A17Cy5EiUHOtRnrpHVT O3h28EdCBjQwCx18fkjbQpcA6LYaDcTO8FOXEs7duuxonEB0jyr8J88iZ/caKf7HEtEMMRgeCu54D t33tof84RhdOobm4wxHFYyNAqBpAXlI+X3B8LYHD8/v9NVOD6bLhjciOWp5tMf4aoVgcdrsA7ZDp+ tuZZPclw==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pnvQa-00DCFp-25; Sun, 16 Apr 2023 05:59:56 +0000 Date: Sat, 15 Apr 2023 22:59:56 -0700 From: Christoph Hellwig To: "Ritesh Harjani (IBM)" Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, Jan Kara , Christoph Hellwig , "Darrick J . Wong" , Ojaswin Mujoo , Disha Goel Subject: Re: [RFCv4 5/9] ext2: Move direct-io to use iomap Message-ID: References: <78fed3db1cd6889b2c26866b9ce3c2538c7a77f7.1681544352.git.ritesh.list@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <78fed3db1cd6889b2c26866b9ce3c2538c7a77f7.1681544352.git.ritesh.list@gmail.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Looks good based on my limited ext2 knowledge: Reviewed-by: Christoph Hellwig