Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp2522927rwe; Sat, 15 Apr 2023 23:05:44 -0700 (PDT) X-Google-Smtp-Source: AKy350ZF5JlEvsXTOVq77dFezgif+Bh/KJ/9bcPS3XZVsWyJKQ+VuNDFpKlQnpVhwuPYZV6VBOlV X-Received: by 2002:a17:903:1ca:b0:1a6:bd5c:649d with SMTP id e10-20020a17090301ca00b001a6bd5c649dmr3545915plh.56.1681625144143; Sat, 15 Apr 2023 23:05:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681625144; cv=none; d=google.com; s=arc-20160816; b=E2qXCONQBgbrw9KhlXN5NpD7gnYUw3Iz9Ag7rtxNglQstP2C3fUdZwCdK8iucnrGJN UFrw3E069EbZ7t6pnVjYwFfyMtBbIWlCycmOA+hr06iBAaoFo6PqRaxtc1XyFOMBFEZW VA0mA8JoIme7ohMm0IyCwAVzEo9GU/OpMLAT7RJf3guBnDYbsD6J4BtvT9plToUJQN4a s16lVd/S3VoyGoUtPBr1gu2NNvQUfUCxUc6ornzAUX0IMlGPt+RFMjZbTr+QBakAcaUJ cYn2dHeryzF916lVhO/BRvIMDtDrLGB6bJdLBdrtymjwvCtyLnjqWVJA1rZmBKXyTztn 8nYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=NRUgc0+3mF8ocmKC/1ZSJa0r0TpeHHNJXlCwzUYF9GM=; b=D2F+sH47taCHhu25c6IDZxRlAQq7nXyp0aaZFlU0+I+z3+S8r8zLl/ljUoW/awf3Ft GP8gomvMZBLoA+RCNfTPKXHvvMU196DQt72aY58bLg8BGMs5T652afCwCXGiV0vCf7wu zE2DJyEqJXz4uvvQoPzK6T1Chdr9fsJC/J+hyBsqt5/InTiffTvrqWYwD/bRKpyYJ4tn diK5DM/rBmY6eZh1tFXzd2bQa1k4wns6vkeFENrjJ74dgMlHb6yZk4/eoEVWkJnj4wKM me6pIPRxvRuaDR9ArJhuua3xzjqoUQVzgW+Y//59/0uFKPohsfFvpg8yilsqNan22Xgv atBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4T4NUOjQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m17-20020a170902db1100b001a6494cf707si9281875plx.268.2023.04.15.23.05.31; Sat, 15 Apr 2023 23:05:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=4T4NUOjQ; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229582AbjDPF4b (ORCPT + 99 others); Sun, 16 Apr 2023 01:56:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229532AbjDPF4b (ORCPT ); Sun, 16 Apr 2023 01:56:31 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A9952D52 for ; Sat, 15 Apr 2023 22:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=NRUgc0+3mF8ocmKC/1ZSJa0r0TpeHHNJXlCwzUYF9GM=; b=4T4NUOjQyzryZsGwLao6txNw+c DFS1Iw7YZaRAuP59pLece1uElls7tnZ0gaZeTTh5Dpii2yUS0w+IjiJijoU6XOkzngjcx8ivio+DZ MwP6T9pdJPOLm67yBqKXGz8gho69vABitwbIcQ0wPC20m+dyFSs9OtIOE17xAvW0bIktqfzmGF8XY kgQovXM6UFgTM5cviH8yEQJHTONi1ZrIgpgRpsVxf5LTd0539deKXz9abAzjc4E9d2S77eaGYeajG 45unRRtrv/POtJGyx7UrPxqiNnbh+RAu+VzvN1EJtJ0gIOiualt3Kq1A2gRMFlOk5jzCGNVAUIZIL OOfe0R2g==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pnvN9-00DC3F-0A; Sun, 16 Apr 2023 05:56:23 +0000 Date: Sat, 15 Apr 2023 22:56:23 -0700 From: Christoph Hellwig To: Christoph Hellwig Cc: William McVicker , Theodore Ts'o , linux-ext4@vger.kernel.org, "Stephen E. Baker" , adilger.kernel@dilger.ca Subject: Re: simplify ext4_sb_read_encoding regression Message-ID: References: <20230416054742.GA5427@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230416054742.GA5427@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sun, Apr 16, 2023 at 07:47:42AM +0200, Christoph Hellwig wrote: > We could do that, but it seems a bit ugly. What prevents symbol_request > from working properly for this case in your setup? To anwer to myself - I guess we need something else than a plain EXPORT_SYMBOL for everything that is used by symbol_request. Which would be a nice cleanly anyway - exports for symbol_request aren't normal exports and should probably have a clear marker just to stand out anyway.