Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sun, 16 Apr 2023 17:24:25 +0530
Message-Id: <873550jb4e.fsf@doe.com>
From:   Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To:     Christoph Hellwig <hch@infradead.org>
Cc:     linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Ojaswin Mujoo <ojaswin@linux.ibm.com>,
        Disha Goel <disgoel@linux.ibm.com>
Subject: Re: [RFCv4 9/9] iomap: Add couple of DIO tracepoints
In-Reply-To: <ZDuOtt6w+ZOcVv9w@infradead.org>
Precedence: bulk

Christoph Hellwig <hch@infradead.org> writes:

> On Sat, Apr 15, 2023 at 01:14:30PM +0530, Ritesh Harjani (IBM) wrote:
>> Add iomap_dio_rw_queued and iomap_dio_complete tracepoint.
>> iomap_dio_rw_queued is mostly only to know that the request was queued
>> and -EIOCBQUEUED was returned. It is mostly iomap_dio_complete which has
>> all the details.
>
> Everything that is here looks good to me.  But it seems like we lost
> the _begin tracepoint?

Sorry, my bad, I might have only partially understood your review
comment then. Will quickly send the next rev.
So in the next rev. will only just add a _begin tracepoint in
__iomap_dio_rw() function. Rest everything should be as is.

Right?