Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp3143295rwe; Sun, 16 Apr 2023 12:45:31 -0700 (PDT) X-Google-Smtp-Source: AKy350bbY86XEmxAhjeI/PA3lWaUC8uKAJ68XO8Ml+inoYDuI/IO10ClJurR/Bowtpytp50GSVz3 X-Received: by 2002:a17:903:1248:b0:1a4:feb8:bc5c with SMTP id u8-20020a170903124800b001a4feb8bc5cmr12494597plh.48.1681674331509; Sun, 16 Apr 2023 12:45:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681674331; cv=none; d=google.com; s=arc-20160816; b=NC5dssw6rx3jnBBlmsMSxdS5vZ5zkQqrCbsKfLQT6jUFIUTKbd4p3W7xeFuMR3jPy9 FuTUa2bqJPYWwgmR4JAalXanyy79xHhpOzKvKx7087M8qTQ0znJ4jZb+KaTEIvoihuA7 yfiZkNAvV0sd5q+w6IEBd0WgxFu1whxSGeGovZMcPyQyZR/J3+9q3Jk+Y/Wz9noee7lO K7cG/qy+9YnuBh2QpKHkobWMSOO5irccTDAL3lnKW2ENSXVSONVO+st/fsljaWuzJiHX a3dFLGwlrqCR0rR1eeT1/7aAJ7GYpvORCNjK4wDnB6TDDSMo7RfvmAsafl1aHQ+bE63m BMNg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=7bnjqogqMaCi/oevc5lkPThEQJP7B6dcOQlaBcO5X9o=; b=vuy3lDyKDlHCqkyIog8JwUc+yVR5gOM1wZpTMS9qByoGnMPt+Z9xtZa3Wt4pQNyN8i A/37TsM1eqy6PiWukrGuMw6zwOPXEvmcL/7y1YVonmLQBsh1LGO+JXBCkB179LLakVWe VnWznt4RjexT6mNYjS/zEfD7HzJAQFySx+SMzek31myRrggU2CFF7/ODnQhXtVeefgix fAM9N+iDRXSVeuV6L+C8JqVC08nWYHg1BEnIcBZkebjEHNQAteGafMgK2u6ppNmLNmrf y9L/6sp446nO5E27wu31uroesrCrDdmFHXGdYLQZdpy9PFfYxyQhNecj5vDQfJc+ou9T T+6g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iRwarQc9; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i15-20020a17090332cf00b001a695c30749si8988303plr.467.2023.04.16.12.45.13; Sun, 16 Apr 2023 12:45:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=iRwarQc9; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229508AbjDPTcN (ORCPT + 99 others); Sun, 16 Apr 2023 15:32:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59220 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229501AbjDPTcL (ORCPT ); Sun, 16 Apr 2023 15:32:11 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AEEF110D4 for ; Sun, 16 Apr 2023 12:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=7bnjqogqMaCi/oevc5lkPThEQJP7B6dcOQlaBcO5X9o=; b=iRwarQc9WSsIr0BSNYwb+F/4w7 KIUxI5VUHy9iR3G6jShDshHgUCd+CUjKxq5QgZA8xYMi5OiwZOYrWeKSw7kS/UuuuiJJb5R+yWD6o kTIlqc6Flng4oCt4hPJ9ThAdFWoAilyzWYrhLTiCWqbtRcEPqAe+5Ppfrq0LdQ403ml1jq44Fcvnd nUt9rpbRhfir9DEc26fnobvBpAzQPYmUVfSj2rSEJE/VbhGZT13NDmHeKppOoRg81/7xjDIed1/UT FHT2MDt3gN4C50uigk0613571jn4CqxkGlw514YR+tZCdknQr1DAtV2OrQ8HfHDIQIcv/4MRHEQaF 2t1DDILg==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1po86Y-00Abra-Rh; Sun, 16 Apr 2023 19:32:06 +0000 Date: Sun, 16 Apr 2023 20:32:06 +0100 From: Matthew Wilcox To: "Ritesh Harjani (IBM)" Cc: linux-ext4@vger.kernel.org, Jan Kara , Ojaswin Mujoo , Disha Goel Subject: Re: [RFCv1 1/4] ext4: kill unused function ext4_journalled_write_inline_data Message-ID: References: <672a2ebb430d05f72d36a35341ce805a8a0ea9a6.1681669004.git.ritesh.list@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <672a2ebb430d05f72d36a35341ce805a8a0ea9a6.1681669004.git.ritesh.list@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, Apr 17, 2023 at 12:01:50AM +0530, Ritesh Harjani (IBM) wrote: > Commit 3f079114bf522 ("ext4: Convert data=journal writeback to use ext4_writepages()") > Added support for writeback of journalled data into ext4_writepages() > and killed function __ext4_journalled_writepage() which used to call > ext4_journalled_write_inline_data() for inline data. > This function got left over by mistake. Hence kill it's definition as > no one uses it. > > Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: Matthew Wilcox (Oracle)