Received: by 2002:a05:6358:53a8:b0:117:f937:c515 with SMTP id z40csp112936rwe; Tue, 18 Apr 2023 18:39:57 -0700 (PDT) X-Google-Smtp-Source: AKy350ZAOtI9gK8wZ0SbgR03viGogK5Lt5WwSR2IzfORes5cEhoAan4ggUVeAXEnPGoJgyZ6j6Xl X-Received: by 2002:a05:6a20:429c:b0:cd:5334:e25e with SMTP id o28-20020a056a20429c00b000cd5334e25emr1967153pzj.17.1681868397678; Tue, 18 Apr 2023 18:39:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681868397; cv=none; d=google.com; s=arc-20160816; b=IKaFiZPsDj7EoBRp8IHDCShC0naMLOmnlIWnqC568mia5cpmQ2u15fknjmU+dPNYgk c5pSQo8JCusQuppQxiCkCPgzhAyWnNlG81eLKx61pDvdl24YRpEcWKxrTTwbyhMJK2/L SCInBjkjIN0qL8imWY0tX4p7mvoCC4xTyytJ+Hs+/KJ23en0FG+YGg4ButbDrzJu5U5C uGgb64scclU5doY8AiG7i+06crt42S+JV7kDRrc8gxHo+a0T+YdWTdh3dIKvYD4Q/HCA Dwz9Ws+2CXYRw70fS0cZHAm2v5RB926bgejv7333H8HPXo+JeGRAXWJW7gyK+36uNe7O JJXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=fORvDtycGEYAP00Go8Gr75NbmrQRJi6legeNyHFvVc4=; b=ZLkvCO+OBUfPslW+3tBJv9d1abbefV4Ost2jrzQbhhJBZZets9H3FwVu5toM6VzDQA daaK1DHkehXXBqRx3Fp28lwUkCo+dQE/thELRmtg8rAhP2Ai6G97LGuo4/3rEet3T9dO yNTgMuJJ+5pW1pa9etJJgyfpwUWiIOYU8jbggtOOHoxWLSzZo3bndrhiIGPDFgqQ/rnx /Mui950svwiOUuF6wzho+UtyG46vLvZQdElP+e0JCONIwwBMYyvRwroCAqDHu0UB9ScO TzIuXJAmfSNXgK6MM7ad8i/X1LYPSx9CBTVfKeD+jHY7Hk/z00SwufhcBLLrpPuyeBih rcXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=LrmAEIyG; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k8-20020a63d848000000b0051805159a1csi14649430pgj.476.2023.04.18.18.39.38; Tue, 18 Apr 2023 18:39:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20221208.gappssmtp.com header.s=20221208 header.b=LrmAEIyG; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231578AbjDSB2b (ORCPT + 99 others); Tue, 18 Apr 2023 21:28:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34676 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230523AbjDSB2a (ORCPT ); Tue, 18 Apr 2023 21:28:30 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1062083F2 for ; Tue, 18 Apr 2023 18:28:29 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-517f1d5645aso604679a12.0 for ; Tue, 18 Apr 2023 18:28:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20221208.gappssmtp.com; s=20221208; t=1681867708; x=1684459708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fORvDtycGEYAP00Go8Gr75NbmrQRJi6legeNyHFvVc4=; b=LrmAEIyGSJiRmmpboUhhQgqPcY35ao1RN/OmUVmJ2+dtZKoCNZbb8NLxueipM+G5cL 7Z8Nwal6Jz63ieQNUvv003Q/cAVuE98OeSDB3Ay0Doy0h7oKAWn5SO9oU40wJCf0tbCQ BQ42zZnn0Cg/VQDTeWslhL7Wd8s61avskpFcinz3IKJk+gNlExkijnMyMDYHJlhUHd5M 8IVAzrRyL0O2Bazz7z+f5qoE6nxJXJFFSe3jLE/4Y/nctAfi6fljhWgSEFtC2xGzhK5C mIW0MC0YJkbwEU94y4kb1t2bC6NCGfVeKEG9Yso2dAk27EpJOXvZk/aks8gm/9xAtK5z hsig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681867708; x=1684459708; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fORvDtycGEYAP00Go8Gr75NbmrQRJi6legeNyHFvVc4=; b=JvSQT/jfS2KtGmCiKI/CEUkoyeey3KhgRz184mRSxlxMVaTw6NXF7ecIxGLvmgawM/ CcsI/+g66IGUwMOZW4rQ4SEpq5YIPnN3vQYWTcEkvZaUsPfZthVKaBNPAXtiKqfdpAFW OPKafnPbxywlUX4GrAt9PlyyJK8AmO1vCGN4STNhRpHCFBKHSo+dSMzNqV06gGF1X7vV DCtJ8tsPyedc2U3C27mogNNkpukrFW69HwUqXKnElmBCdwOk9veAWQ/Dw8iB+/PcnBpE URiWB2m1UxlbDAUzaiJOfLJh+8HBIINGnhrkQh8sZbuSdgo91R5PZShbsWlmc+aMLBu4 3DPg== X-Gm-Message-State: AAQBX9fXM3JHFH2DCF6wHvL7e5KapB4fvTCyi9nJD+uoxkIS9NgnKvQS lpwf9FhVUDRfSi+16F/evDghbQ== X-Received: by 2002:a17:902:dad1:b0:1a1:956d:2281 with SMTP id q17-20020a170902dad100b001a1956d2281mr19890233plx.3.1681867708384; Tue, 18 Apr 2023 18:28:28 -0700 (PDT) Received: from [192.168.1.136] ([198.8.77.157]) by smtp.gmail.com with ESMTPSA id x24-20020a1709027c1800b001a50ede5086sm10206660pll.51.2023.04.18.18.28.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Apr 2023 18:28:28 -0700 (PDT) Message-ID: Date: Tue, 18 Apr 2023 19:28:26 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH 1/2] fs: add FMODE_DIO_PARALLEL_WRITE flag Content-Language: en-US To: Dave Chinner , Bernd Schubert Cc: Miklos Szeredi , "Darrick J. Wong" , Christoph Hellwig , "io-uring@vger.kernel.org" , "linux-ext4@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , "linux-xfs@vger.kernel.org" , Dharmendra Singh References: <20230307172015.54911-2-axboe@kernel.dk> <20230412134057.381941-1-bschubert@ddn.com> <20230414153612.GB360881@frogsfrogsfrogs> <20230418221300.GT3223426@dread.disaster.area> From: Jens Axboe In-Reply-To: <20230418221300.GT3223426@dread.disaster.area> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On 4/18/23 4:13?PM, Dave Chinner wrote: >>> Without first attempting to answer those questions, I'd be reluctant >>> to add FMODE_DIO_PARALLEL_WRITE to fuse. > > I'd tag it with this anyway - for the majority of apps that are > doing concurrent DIO within EOF, shared locking is big win. If > there's a corner case that apps trigger that is slow, deal with them > when they are reported.... Agree, the common/fast case will be fine, which is really the most important part. -- Jens Axboe