Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp1064759rwr; Thu, 20 Apr 2023 09:29:37 -0700 (PDT) X-Google-Smtp-Source: AKy350bT1zC+/+H2/wrc3YHwHhr8Ykh2pYg/54BetqGEfBORLOJKH3pxIfbr4RE/jVzePvoSDra3 X-Received: by 2002:a17:903:2987:b0:1a6:bb7b:7a40 with SMTP id lm7-20020a170903298700b001a6bb7b7a40mr2012600plb.64.1682008176762; Thu, 20 Apr 2023 09:29:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1682008176; cv=none; d=google.com; s=arc-20160816; b=zG5q8R6nj/Z4raU6C56hlNjKYTEEGsjIGQ3Qq9Xyk6l3mpMnh/OsvWf3NFH0HexrqY VcdUaHI6Qpu/wBs4u5VXHET5/O1mQ/Nl5Wca4+iQqnAXAPvHRxCHoauoulpbr7hQyPL8 5xLHGPx9n4bJCsbKFrp0OqHz7zCny53yGr2JFqxhMRSQH14/asUp1+Y3Tlq6YNm6SK+0 70G5KTNdCOZ4B9hgvWpfQT0GYvyXtNzT53XsdeQy6/0o1h5sV9cJhbmwt4a6nayK2LGz 7MEtuPrIq41wbHAlT7yDEwqvEYo1NDVbAFLwqsLM3ZKGxsvb1fx1m6HOLv2Ri0QuV73O VzhA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=l89AU5QGIzfnCGpsX+jKS6186ftCA2OuhktbME1l6WE=; b=eDW5LDAtkmVr1hlu63Rxdg8qQZ+CcqDrD3cdH4buXmiNv9TsNgceucoE+qDEZmmnXY gyHzKEEwL7i44mdDYRfch7Ad1QNB3v6B2OBJ1rrZziRlpLs8MIjrnBEISgEydjLgqxMC VhsNLsuKKq71oAmBxIIqWBlwl8oM3SfZwqTHCaXUWwhqra/LMH2Ijw3HwlvNQqP1gLWH /99dYvl7QwU5Q8rummFzG9Bk1YoaRjLmFMEdNq3UgB+Z82vUpSnY0Fqtn65ewm72tqoF QKCnC+8OJzMrtpwxs8eXGvJefY9nmF/cHivupfd+N5fn05wCQMC7AFYFgpM77P5Pi9Q/ Dp3w== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=nPqnnTfI; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id i5-20020a170902c94500b001a8a110407esi2203513pla.540.2023.04.20.09.29.00; Thu, 20 Apr 2023 09:29:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@mit.edu header.s=outgoing header.b=nPqnnTfI; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mit.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231731AbjDTQWB (ORCPT + 99 others); Thu, 20 Apr 2023 12:22:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231906AbjDTQV7 (ORCPT ); Thu, 20 Apr 2023 12:21:59 -0400 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83B4D3C38 for ; Thu, 20 Apr 2023 09:21:58 -0700 (PDT) Received: from cwcc.thunk.org (pool-173-48-120-46.bstnma.fios.verizon.net [173.48.120.46]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 33KGLqxW022542 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 20 Apr 2023 12:21:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1682007714; bh=l89AU5QGIzfnCGpsX+jKS6186ftCA2OuhktbME1l6WE=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=nPqnnTfIkYqKkhmMgYeF6+V1GOkS8gCtpqRlOiCRE948QaHEIGYGBk2RRbZTFKjoG OtVy4EKJQp4nLdKcPN91cpYLzTY5u1qZ9j6M1cptUrNCD0K9JLZTmAW/2nBGPd5+dl 21q23ZL5f6OYgZafv3jzLlT6PXUUkMW5Loz4CE+DqF2ZdzZJvfKhPqLdj3u2R5Glo9 rHNq2f2V4deZbUP2qva/ok8FbnD+fvWuf2DLa9J60Bfx1kwODnYBiFnM8mWQ6yYero L2IZVQfbA0PurxiMpDNP5PSRAfVKb9qArDatzYA7v7jXGHTKVsrepG1BWTlcE6JdTT ZUYMZj88UgHBA== Received: by cwcc.thunk.org (Postfix, from userid 15806) id E676515C543D; Thu, 20 Apr 2023 09:47:12 -0400 (EDT) From: "Theodore Ts'o" To: adilger.kernel@dilger.ca, Tom Rix Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ext4: remove unneeded check of nr_to_submit Date: Thu, 20 Apr 2023 09:47:09 -0400 Message-Id: <168199842265.1078192.14715172373184437380.b4-ty@mit.edu> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230316204831.2472537-1-trix@redhat.com> References: <20230316204831.2472537-1-trix@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, 16 Mar 2023 16:48:31 -0400, Tom Rix wrote: > cppcheck reports > fs/ext4/page-io.c:516:51: style: > Condition 'nr_to_submit' is always true [knownConditionTrueFalse] > if (fscrypt_inode_uses_fs_layer_crypto(inode) && nr_to_submit) { > ^ > This earlier check to bail, makes this check unncessary > /* Nothing to submit? Just unlock the page... */ > if (!nr_to_submit) > return 0; > > [...] Applied, thanks! [1/1] ext4: remove unneeded check of nr_to_submit commit: 8ae56b4e82ee29b5cc1fbea8b00a0a7e0758f3c2 Best regards, -- Theodore Ts'o