Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 21 Apr 2023 17:35:47 +0530
Message-Id: <87edodigo4.fsf@doe.com>
From:   Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To:     Jan Kara <jack@suse.cz>
Cc:     linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
        Jan Kara <jack@suse.cz>, Christoph Hellwig <hch@infradead.org>,
        "Darrick J . Wong" <djwong@kernel.org>,
        Ojaswin Mujoo <ojaswin@linux.ibm.com>,
        Disha Goel <disgoel@linux.ibm.com>, Ted Tso <tytso@mit.edu>
Subject: Re: [PATCHv6 0/9] ext2: DIO to use iomap
In-Reply-To: <20230421112324.mxrrja2hynshu4b6@quack3>
Precedence: bulk

Jan Kara <jack@suse.cz> writes:

> Hello Ritesh,
>
> On Fri 21-04-23 15:16:10, Ritesh Harjani (IBM) wrote:
>> Hello All,
>>
>> Please find the series which rewrites ext2 direct-io path to use modern
>> iomap interface.
>
> The patches now all look good to me. I'd like to discuss a bit how to merge

Thanks Jan,


> them. The series has an ext4 cleanup (patch 3) and three iomap patches

Also Patch-3 is on top of ext4 journalled data patch series of yours,
otheriwse we might see a minor merge conflict.

https://lore.kernel.org/all/20230329154950.19720-6-jack@suse.cz/

> (patches 6, 8 and 9). Darrick, do you want to take the iomap patches through
> your tree?
>
> The only dependency is that patch 7 for ext2 is dependent on definitions
> from patch 6

That's right. Patch 6 defines TRACE_IOCB_STRINGS definition which both
ext2 and iomap tracepoints depend upon.

> so I'd have to pull your branch into my tree. Or I can take
> all the iomap patches through my tree but for that it would be nice to have
> Darrick's acks.
>
> I can take the ext4 patch through my tree unless Ted objects.

Sure, we might have to merge with Ted's ext4 tree as well to avoid the
merge conflict I mentioned above.

>
> I guess I won't rush this for the coming merge window (unless Linus decides
> to do rc8) but once we settle on the merge strategy I'll push out some

Ok.

> branch on which we can base further ext2 iomap conversion work.
>

Sure, will this branch also gets reflected in linux-next for wider testing?

-ritesh