Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH] fs/ext4/super.c : fix two compile errors
To:     Chris Clayton <chris2553@googlemail.com>,
        "tytso@mit.edu >> Theodore Y. Ts'o" <tytso@mit.edu>,
        <linux-ext4@vger.kernel.org>
References: <7ca8f790-c14e-6449-f3b5-4214d3fb1e61@googlemail.com>
From:   Jason Yan <yanaijie@huawei.com>
Message-ID: <130cdccf-5bd6-bf67-4a2b-7f13fda0de3a@huawei.com>
Date:   Thu, 27 Apr 2023 09:32:02 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.12.0
MIME-Version: 1.0
In-Reply-To: <7ca8f790-c14e-6449-f3b5-4214d3fb1e61@googlemail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2023/4/27 5:20, Chris Clayton wrote:
> dcbf87589d90 results in 2 build errors in fs/ext4/super.c because, in both affected
> functions, a variable is left unused if CONFIG_QUOTA is not defined. The patch
> below fixes this. It is compile tested only.
> 
> ...
>    CC      fs/ext4/super.o
> fs/ext4/super.c: In function 'ext4_put_super':
> fs/ext4/super.c:1262:13: error: unused variable 'i' [-Werror=unused-variable]
>   1262 |         int i, err;
>        |             ^
> fs/ext4/super.c: In function '__ext4_fill_super':
> fs/ext4/super.c:5200:22: error: unused variable 'i' [-Werror=unused-variable]
>   5200 |         unsigned int i;
>        |                      ^
> cc1: all warnings being treated as errors
> ...
> 
> Fixes:  dcbf87589d90 (ext4: factor out ext4_flex_groups_free())
> Signed-off-by: Chris Clayton<chris2553@googlemail.com>

There are already fixes. But still thank you for the patch.

http://patchwork.ozlabs.org/project/linux-ext4/patch/20230420-ext4-unused-variables-super-c-v1-1-138b6db6c21c@kernel.org/
http://patchwork.ozlabs.org/project/linux-ext4/patch/20230421070815.2260326-1-arnd@kernel.org/

Best wishes,
Jason