Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp4486195rwr; Mon, 8 May 2023 08:19:04 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ySO0buHN/HrpObuaxeXt0iVP9aqUoKBEYCW0vDQ3C7WTdPG10hWlK21J7j9nIg4SPVY8d X-Received: by 2002:a17:902:9346:b0:1aa:ef83:34be with SMTP id g6-20020a170902934600b001aaef8334bemr10077332plp.47.1683559144187; Mon, 08 May 2023 08:19:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683559144; cv=none; d=google.com; s=arc-20160816; b=Ubq2vDavf7yg2zKNPEYSsJ4f7vsbfSGnbGXhrSlTiuERdFVjU0c5ZuW2nle7NvD0+6 gZHxHU9MC5T2uTHpY6ItUG2fhjKFmhk8WsP7nhfJORKMV936KTwNscFXFXAkBVX8nYY9 Or04XAkVpZXXFAfE0zk9kf/3A3Pw6GP5An/d2D+i3LqXPGM/lbzdZqvI8HD29z5rnwAe y1hAQ+EiZtu3m7685PjdhONuZjsW1JkYUHVtJ5AwtIrs0iYJRVGyZDi7RAncFFKLvzRM 4rNlY6nf1Mh+faXx6yhroQaB6QBgA1uwOKHckfZNsy0StQqce1iBxEYyB6GCIa3x76AT cEFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=k2NhpEht6/YcxE5v+acQwgEzjbdaWwnCz06L3qNmxkA=; b=kuIz3MmytAg40HxAJSEgTOYeBAL+oIySx7WSlq7KiHU5Bm7bXz3AmkifHhAnlebK2C lf8+TX/E3VXfasacyepwKaziDh9US1iHoKsmJ6BYr+8USkkmhAN2UOpr2Y0iFkdBtYvX iH2XvHebTs817diPS1XyUW+0jUgvbFiP4fdSbRf/iohcEct1Z8qcI42dvB/zl+PgJYzG 1GerS/nKLv6zb5ajJzSDLwlYOjSk8WZ5Y7psLSfaxJ021skLQtgvG/BIoMmf+xCzZaDo vjgo3miDTKwhGtY+Fe16TIQNQoRwSMpnBZaEb3pIU9sScj2fuwH6YJhhf711PnE7gLqv 1JkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DDKTap0L; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c16-20020a170902d49000b001ac307c4ef4si8620958plg.301.2023.05.08.08.18.15; Mon, 08 May 2023 08:19:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=DDKTap0L; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234178AbjEHPNr (ORCPT + 99 others); Mon, 8 May 2023 11:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230414AbjEHPNq (ORCPT ); Mon, 8 May 2023 11:13:46 -0400 Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D527697 for ; Mon, 8 May 2023 08:13:44 -0700 (PDT) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2ad89c7a84fso19535471fa.2 for ; Mon, 08 May 2023 08:13:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683558823; x=1686150823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=k2NhpEht6/YcxE5v+acQwgEzjbdaWwnCz06L3qNmxkA=; b=DDKTap0L3LTjkBLPSZKpyFRcYXZcgt6wXyhHzFxSrPKOWksrMR+wAz9r0o9TnP9vaf a3EtL0MerHyp32m0Kqi5I9kX0g8bOxMWZUnzib6Hmfyo97MShejspCiqup62tl8u9FFr 8Ch1HwNK/kVZmLFkFYqaYRUZtufPqo/yiKAz1HRTV6GWcoek7MhrkqlGfj6+rV/oONAP 8W5Tbqbtl+dQ0wY+clvnITwRJ5lFzJPwQiE5YNzu/jOlRSfBnUz92lAjCgXYBjOZBkRh DdIvC0edzOnSZlQyn9Ovx/GTLpcvjQxpAsE2WKLAPoVewA5plobvV+8b5vEXU4c+uWjr Z19A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683558823; x=1686150823; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=k2NhpEht6/YcxE5v+acQwgEzjbdaWwnCz06L3qNmxkA=; b=EQMdKZnUx37SG/z9feOlhvj4PNDyOC7LIOhmAPw/WmJxPRysDCB/bT3evDfeWsALb7 TO/b2hU8Peh+uiV+/CpEllTR64oRBeL/jhI0qNZRdQ1RDXx5KSUE7g8Ri7Cu/kXxU32J mBiAMpdi5tH3aayghrINBR202yOzi0rYcvoV1qcp+PqlDsSAibzf1hzvPB3GqYbBWlaa 7eMgf5/trbnRkkWbXUNZzILeCEkTaXhZFD+fYEE7Hy9ASBoX9D2nO/uMwUrse4+ekDrT iJp4Gz5aqrQ+um51NLH2AhWnnH3n7bGG2F6NyJPtbBqeHtA2LE7Ad4ed2vhE2ulgRfxz NXPQ== X-Gm-Message-State: AC+VfDwUUzD0XXe9iGA4aLwlClCVsj7jjDtsSpsgwsXQfcCxzbUYKtrP 3puGqNFU2OpiLfVgEPJPZXIDU7u+jAf8s/D6Rds= X-Received: by 2002:a19:f004:0:b0:4f1:223c:dc83 with SMTP id p4-20020a19f004000000b004f1223cdc83mr2477949lfc.48.1683558823069; Mon, 08 May 2023 08:13:43 -0700 (PDT) Received: from ta1.c.googlers.com.com (61.215.228.35.bc.googleusercontent.com. [35.228.215.61]) by smtp.gmail.com with ESMTPSA id s12-20020ac25fac000000b004eff32d6a21sm19641lfe.121.2023.05.08.08.13.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 May 2023 08:13:42 -0700 (PDT) From: Tudor Ambarus To: tytso@mit.edu Cc: adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, joneslee@google.com, Tudor Ambarus Subject: [PATCH] ext4: remove superfluous check that pointer is not NULL Date: Mon, 8 May 2023 15:13:37 +0000 Message-ID: <20230508151337.79304-1-tudor.ambarus@linaro.org> X-Mailer: git-send-email 2.40.1.521.gf1e218fcd8-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org If @buffer is NULL, no operation is performed for kvfree(buffer), remove superfluous check. Signed-off-by: Tudor Ambarus --- fs/ext4/xattr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index dfc2e223bd10..6778c6eb6e30 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -2676,7 +2676,7 @@ static int ext4_xattr_move_to_block(handle_t *handle, struct inode *inode, out: kfree(b_entry_name); - if (needs_kvfree && buffer) + if (needs_kvfree) kvfree(buffer); if (is) brelse(is->iloc.bh); -- 2.40.1.521.gf1e218fcd8-goog