Received: by 2002:a05:6358:9144:b0:117:f937:c515 with SMTP id r4csp6078499rwr; Tue, 9 May 2023 09:56:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4jf2SDvyqyYDgr9tVDr/0b833hFWYnNXZ4zlS8W3rZVdS3Q9Da1osrTL2nQ8k5hne35r13 X-Received: by 2002:a17:902:ecd0:b0:1ac:76a6:a1f with SMTP id a16-20020a170902ecd000b001ac76a60a1fmr9641453plh.16.1683651380561; Tue, 09 May 2023 09:56:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1683651380; cv=none; d=google.com; s=arc-20160816; b=rC7XkvLjxeO0SGkalLx6dCnSyGDOaTolOa9DqDH07ylFp2gKfHhTahDz3X11IrD/Ts TaJzb6bmmqHUQibEVAehp3/xp48y/aGiQJ8EXF3vtO7NDc84smlJS6BudYbPp4efIJXg G1g34YCQAWgcG27jZOxNd2vex0IrLPHtEwDS6tHmFTRiSlTpK8pFvmv8OyGwiXoNX60Q F4QC0ptoXl4VGI2VQv7uwHRrxNUzje9mXLsSZlQIG8SxWdAceTe1eKMmEyuWyiok+XJ0 rjKhBk0QPhTOuiA0UXNRBELU5hyxoVJO3sUxsixDGqDbL75MDVuP5u4lFgscu6/51fvU Hgnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=8AiXugarlhHToBN2ueOGwWaX5E4llz8s13EASoB3wVI=; b=ImzBrXGx1Fw/7YW/w7bXq2YMo5+M12oTNWr7SX81oD/1l/EG5f7E6UhTRTE1hnB2hF 2SEl8y2FcGg7U1V1GCG8jY6p4iOAOiUevapYzB6qHc2zMc9pjD0RKiiv3eywdDJYmmDI fl+0/xlItBQj2JL85ZtX/d1vJEvBgnvomWWEHhUzgEMY8KGic86cw+Joklays4SO/WRO iIwa7TRPHGZKKTGMIzfIPMqcwNg77h3bWkGv7v9HviOZJaLK0T27Rgq1Z9QYijPLS20w xF+iRtUYYy+RVkNxvLRNODVXuuOowNBAqTj/G+T1RPZQIUV946VNy6lh+hNgXdwxwhIp Lo2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u13-20020a17090341cd00b001a1bbc5bea5si1989438ple.537.2023.05.09.09.56.04; Tue, 09 May 2023 09:56:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234507AbjEIQwa (ORCPT + 99 others); Tue, 9 May 2023 12:52:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34844 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjEIQw2 (ORCPT ); Tue, 9 May 2023 12:52:28 -0400 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A03AA19B3 for ; Tue, 9 May 2023 09:51:41 -0700 (PDT) Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-75131c2997bso2273266685a.1 for ; Tue, 09 May 2023 09:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683651101; x=1686243101; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8AiXugarlhHToBN2ueOGwWaX5E4llz8s13EASoB3wVI=; b=KFzB3b17C1WoC0FNNaac6KG/S5ShYzk35IznCDabiVxbf2XjsYkUdd1emhHoM7Hzfs afgt6QDLqLjocD5GHpi9ggy56UnXR95a+PI8jx4fYOHw00kysoUsSIOqqjXrbXka7qxM F7wiKmSppEcpftU2dGTyhBq3s07oJp32NxkvbPH/NBxbpbkfsD1ObrIt9D7Qj1VDZyNr HfhHlQuJ8F4103Ob0dfyEsRYJ3FW/zkTgQDmJtiGDXdmEPLfY9lprx8oJETPBFSTop5s eK0HdibVsI3dz+8JOIyIaPFBHZd8+0Duq7W0QpmgliqbApdqhnUWTcKqoxAO/XBt90Io 0NDA== X-Gm-Message-State: AC+VfDzgluhZPD+5TK65DdR9WIM7/Y8EGHm/PXyG4uiPrwLJR8LkpDhd yj0wQfcSimGN6oZevG/pjFcX X-Received: by 2002:a05:6214:29c7:b0:56e:c066:3cd2 with SMTP id gh7-20020a05621429c700b0056ec0663cd2mr19939922qvb.2.1683651100740; Tue, 09 May 2023 09:51:40 -0700 (PDT) Received: from localhost ([217.138.208.150]) by smtp.gmail.com with ESMTPSA id m4-20020a0cf184000000b0061b3338d6d9sm890247qvl.50.2023.05.09.09.51.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 09:51:40 -0700 (PDT) Date: Tue, 9 May 2023 12:51:38 -0400 From: Mike Snitzer To: Sarthak Kukreti Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , Theodore Ts'o , "Michael S. Tsirkin" , "Darrick J. Wong" , Jason Wang , Bart Van Assche , stable@vger.kernel.org, Christoph Hellwig , Andreas Dilger , Stefan Hajnoczi , Brian Foster , Alasdair Kergon Subject: Re: [PATCH v6 1/5] block: Don't invalidate pagecache for invalid falloc modes Message-ID: References: <20230420004850.297045-1-sarthakkukreti@chromium.org> <20230506062909.74601-1-sarthakkukreti@chromium.org> <20230506062909.74601-2-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230506062909.74601-2-sarthakkukreti@chromium.org> X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Sat, May 06 2023 at 2:29P -0400, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer