Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 9 May 2023 20:22:11 -0400
From:   "Theodore Ts'o" <tytso@mit.edu>
To:     Jan Kara <jack@suse.cz>
Cc:     Ext4 Developers List <linux-ext4@vger.kernel.org>,
        syzbot+e2efa3efc15a1c9e95c3@syzkaller.appspotmail.com
Subject: Re: [PATCH 1/2] ext4: allow ext4_get_group_info() to fail
Message-ID: <ZFrjs2i9xK+ektHd@mit.edu>
References: <20230430154311.579720-1-tytso@mit.edu>
 <20230430154311.579720-2-tytso@mit.edu>
 <20230507181816.tsnqhzgajftcbsz5@quack3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230507181816.tsnqhzgajftcbsz5@quack3>
Precedence: bulk

On Sun, May 07, 2023 at 08:18:16PM +0200, Jan Kara wrote:
> The patch looks good except for one small problem already found by Julia:
> 
> > @@ -2578,7 +2595,7 @@ void ext4_mb_prefetch_fini(struct super_block *sb, ext4_group_t group,
> >  		gdp = ext4_get_group_desc(sb, group, NULL);
> >  		grp = ext4_get_group_info(sb, group);
> >  
> > -		if (EXT4_MB_GRP_NEED_INIT(grp) &&
> > +		if (grp && grp && EXT4_MB_GRP_NEED_INIT(grp) &&
> 		    ^^^ one of these should be gdp.
> 
> With this fixed feel free to add:
> 
> Reviewed-by: Jan Kara <jack@suse.cz>

Thanks for the review, fixed in my tree.

       	       	       	     	   - Ted