Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Subject: Re: [PATCH v3 11/19] ext4: fix wrong unit use in ext4_mb_new_blocks
To:     Ojaswin Mujoo <ojaswin@linux.ibm.com>
Cc:     tytso@mit.edu, adilger.kernel@dilger.ca,
        linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20230417110617.2664129-1-shikemeng@huaweicloud.com>
 <20230417110617.2664129-12-shikemeng@huaweicloud.com>
 <ZF3fJmzhUe2btLrf@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
From:   Kemeng Shi <shikemeng@huaweicloud.com>
Message-ID: <c36ce5ee-5631-efaa-c502-a271ef106860@huaweicloud.com>
Date:   Fri, 12 May 2023 16:06:51 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <ZF3fJmzhUe2btLrf@li-bb2b2a4c-3307-11b2-a85c-8fa5c3a69313.ibm.com>
Content-Type: text/plain; charset=gbk
Content-Transfer-Encoding: 7bit
Precedence: bulk


on 5/12/2023 2:39 PM, Ojaswin Mujoo wrote:
> On Mon, Apr 17, 2023 at 07:06:09PM +0800, Kemeng Shi wrote:
>> Function ext4_mb_new_blocks_simple needs count in cluster. Function
> 
> So there seems to be a typo in the commit header and commit message. I believe
> you mean ext4_mb_free_blocks() and ext4_mb_free_blocks_simple() ?
> Hi Ojaswin, thanks for review. Yes, it's a typo, I mean ext4_free_blocks and
ext4_mb_free_blocks_simple. I will fix the commit in next version.
> If that is the case, once corrected feel free to add:
> 
> Reviewed-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>


-- 
Best wishes
Kemeng Shi