Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20230428185517.1201-1-sunjunchao2870@gmail.com> <20230502094158.tubal42rp2khprah@quack3>
In-Reply-To: <20230502094158.tubal42rp2khprah@quack3>
From:   JunChao Sun <sunjunchao2870@gmail.com>
Date:   Mon, 15 May 2023 20:06:39 +0800
Message-ID: <CAHB1NagDZjigky_JqwRyURYnt=Nmjuf3eWLFsiUWmRgYSW5Ayw@mail.gmail.com>
Subject: Re: [PATCH] ext4: Optimize memory usage in xattr
To:     Jan Kara <jack@suse.cz>
Cc:     linux-ext4@vger.kernel.org, tytso@mit.edu
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Friendly ping...

Jan Kara <jack@suse.cz> =E4=BA=8E2023=E5=B9=B45=E6=9C=882=E6=97=A5=E5=91=A8=
=E4=BA=8C 17:41=E5=86=99=E9=81=93=EF=BC=9A
>
> On Fri 28-04-23 11:55:17, JunChao Sun wrote:
> > Currently struct ext4_attr_info->in_inode use int, but the
> > value is only 0 or 1, so replace int with bool.
> >
> > Signed-off-by: JunChao Sun <sunjunchao2870@gmail.com>
>
> Looks fine. Feel free to add:
>
> Reviewed-by: Jan Kara <jack@suse.cz>
>
>                                                                 Honza
>
> > ---
> >  fs/ext4/xattr.c | 8 ++++----
> >  fs/ext4/xattr.h | 2 +-
> >  2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c
> > index 767454d..d57408c 100644
> > --- a/fs/ext4/xattr.c
> > +++ b/fs/ext4/xattr.c
> > @@ -1639,7 +1639,7 @@ static int ext4_xattr_set_entry(struct ext4_xattr=
_info *i,
> >       struct ext4_xattr_entry *last, *next;
> >       struct ext4_xattr_entry *here =3D s->here;
> >       size_t min_offs =3D s->end - s->base, name_len =3D strlen(i->name=
);
> > -     int in_inode =3D i->in_inode;
> > +     bool in_inode =3D i->in_inode;
> >       struct inode *old_ea_inode =3D NULL;
> >       struct inode *new_ea_inode =3D NULL;
> >       size_t old_size, new_size;
> > @@ -2354,7 +2354,7 @@ static struct buffer_head *ext4_xattr_get_block(s=
truct inode *inode)
> >               .name =3D name,
> >               .value =3D value,
> >               .value_len =3D value_len,
> > -             .in_inode =3D 0,
> > +             .in_inode =3D false,
> >       };
> >       struct ext4_xattr_ibody_find is =3D {
> >               .s =3D { .not_found =3D -ENODATA, },
> > @@ -2441,7 +2441,7 @@ static struct buffer_head *ext4_xattr_get_block(s=
truct inode *inode)
> >               if (ext4_has_feature_ea_inode(inode->i_sb) &&
> >                   (EXT4_XATTR_SIZE(i.value_len) >
> >                       EXT4_XATTR_MIN_LARGE_EA_SIZE(inode->i_sb->s_block=
size)))
> > -                     i.in_inode =3D 1;
> > +                     i.in_inode =3D true;
> >  retry_inode:
> >               error =3D ext4_xattr_ibody_set(handle, inode, &i, &is);
> >               if (!error && !bs.s.not_found) {
> > @@ -2467,7 +2467,7 @@ static struct buffer_head *ext4_xattr_get_block(s=
truct inode *inode)
> >                                */
> >                               if (ext4_has_feature_ea_inode(inode->i_sb=
) &&
> >                                   i.value_len && !i.in_inode) {
> > -                                     i.in_inode =3D 1;
> > +                                     i.in_inode =3D true;
> >                                       goto retry_inode;
> >                               }
> >                       }
> > diff --git a/fs/ext4/xattr.h b/fs/ext4/xattr.h
> > index 824faf0..355d373 100644
> > --- a/fs/ext4/xattr.h
> > +++ b/fs/ext4/xattr.h
> > @@ -113,7 +113,7 @@ struct ext4_xattr_info {
> >       const void *value;
> >       size_t value_len;
> >       int name_index;
> > -     int in_inode;
> > +     bool in_inode;
> >  };
> >
> >  struct ext4_xattr_search {
> > --
> > 1.8.3.1
> >
> --
> Jan Kara <jack@suse.com>
> SUSE Labs, CR