Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1136102rwd; Tue, 16 May 2023 12:19:54 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4CbuguhQ20Q0p5E2f9VUJauJDnt+/KNFbrWaz5v9MNalYvfhQGGa9jxGdyFMclaP6oafTr X-Received: by 2002:a05:6a00:cca:b0:643:7fcf:836d with SMTP id b10-20020a056a000cca00b006437fcf836dmr55218439pfv.25.1684264793708; Tue, 16 May 2023 12:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684264793; cv=none; d=google.com; s=arc-20160816; b=QL3PJABmJA6yroKJ8y6P9Mpbwjz8gF0LWjm0CA4kvOOm6fYD7KaOpYJIaaHIjczO2y sIu5zB2Nu3c2UiUCNRi1vepMsqOrA6V+BBoTN1jvHsNAVUUREogRMV0fh7DmB25sxC9t JJxLh4YM2tJpCOrePPsg9o6i7QeYrVHuhvnHaKo+y9HmUwxtygy4oavpaKDM6rtb7iUV w0YpuAuSKr99dfqNhL4nopEiJPSeScj8pJIU+TPcov4Y9pLl5RNjlucDLnfNmNzThZeZ FXF4RN245D/PtdLAFG28/yDNku/Ce7Z/3UVCIRbIjqHfSWu0ATMHjgAJtlsRHqMbF2nK e7UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xRrYtCC/Q/xk6LM7k4L4zCnW+DwqYTGt4KRN+Qhhzjo=; b=iLxYJZPwrRcZnjvwQY4Zm4XbQYPaqLUThEk1Nu/bkm3G5nt7O5che/cHLD4ZuEQWrP srG3E6Iz8WrAELWYpopg5G81GtUG3RIGj42BFmwGwCx1QG41puSi8UrbCKIEoauh5tfN ImGpaYBgoi8UZ77qBiN26wkinS51hqBPu3TSuvMT0MZVG7bD6OjdTCCXnqf2lZuEvZIq PG0Y/25g9iT92z91EQ8+bAmTeVFIhAGwW6YFl3nieDJoK8P789hcHYVmnZDUbTFEW1Zk 7//wofWrod7bFCwy0CeSrCqKQVC3VbFUBHa/nilXmhQf4sHk3vFh37P17f0mcNx5QpGS iH0A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mm+2oFlY; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x3-20020a63b343000000b00502d81ecf19si20044275pgt.646.2023.05.16.12.19.31; Tue, 16 May 2023 12:19:53 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=mm+2oFlY; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229544AbjEPTOk (ORCPT + 99 others); Tue, 16 May 2023 15:14:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229539AbjEPTOk (ORCPT ); Tue, 16 May 2023 15:14:40 -0400 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A41A171A; Tue, 16 May 2023 12:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xRrYtCC/Q/xk6LM7k4L4zCnW+DwqYTGt4KRN+Qhhzjo=; b=mm+2oFlYGXMbz1khF3q/F+eS/P uHEJ/auwusF8GkGqcUJwVono2Lo8XsSo9jJy++k/ewwizRZ4T/7oU0GUBkTMPqCcPM2YwFa+eB0sN ZdcT4H7ZDuWJcGJPcMkMpbbL3eCbDv8xxsciO0tOSxhkAXTIBMcxzy/PdWsch01n7EgUFXctKJQsp DcKf7yQ1hsBT+OTfI3/quNP98kK6p9TxjN5kjhPo0qz1gqMoYx6Jh10TvTZp46Vuak3Z4CWAHQkdb nKmJXjHkP2b4qxBco845JD6mVps9F4qwOsithMOnYMYilrj7SWJyO48SD5Z1eu9ZlXCXMCMTVGxFw viRU+NKw==; Received: from willy by casper.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1pz084-004Tux-2O; Tue, 16 May 2023 19:14:36 +0000 Date: Tue, 16 May 2023 20:14:36 +0100 From: Matthew Wilcox To: "Ritesh Harjani (IBM)" Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org, Ojaswin Mujoo , Disha Goel Subject: Re: [RFCv2 2/5] ext4: Remove PAGE_SIZE assumption of folio from mpage_submit_folio Message-ID: References: <74182f5607ccfc3b1e7f08737fcb3442b42a2124.1684122756.git.ritesh.list@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <74182f5607ccfc3b1e7f08737fcb3442b42a2124.1684122756.git.ritesh.list@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Mon, May 15, 2023 at 04:10:41PM +0530, Ritesh Harjani (IBM) wrote: > mpage_submit_folio() was converted to take folio. Even though > folio_size() in ext4 as of now is PAGE_SIZE, but it's better to > remove that assumption which I am assuming is a missed left over from > patch[1]. > > [1]: https://lore.kernel.org/linux-ext4/20230324180129.1220691-7-willy@infradead.org/ > > Signed-off-by: Ritesh Harjani (IBM) Reviewed-by: Matthew Wilcox (Oracle)