Received: by 2002:a05:6358:3188:b0:123:57c1:9b43 with SMTP id q8csp1943388rwd; Thu, 18 May 2023 21:18:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ63dzxb5i3yYU1Mp6msFjWkFM2akX684YdJF3FwDaDeMY4V4hxCmUhwkMnjypv3Jz21rfMr X-Received: by 2002:a17:902:ba8b:b0:1ae:5f7e:c127 with SMTP id k11-20020a170902ba8b00b001ae5f7ec127mr1311094pls.40.1684469907512; Thu, 18 May 2023 21:18:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684469907; cv=none; d=google.com; s=arc-20160816; b=0udC6/dpxB5V6UZIFMt7CKN2/EV7eEJ/AyP899Ey0ZN0DJTSpjzf3P+Nu866Gr2jFv rFFLfe1HLJq/rXyMAqlvxjyAChDA+W1S5N7Z8SUI/Awq/p5bB508iPArdW6zwdcbEVSl lScWnHfoxYp/6K+fA9NuDJVny7YHZMzX9dYYdj3v4ERnh3obn6apKkhw00CEBLQWeveC t+pWXNZ4H3bnTelt5Q7h26TspDsEXLTImmpY1ldXCUYZMUE/iq1iQzGirKWj8YBtFg3e Md/PHRzdwnRhYb2EyW+98O3vhHe1ascVJ03GZBtC6tcInruO8AgcwejvNCXKyqC6rK9I fzsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=xzy+7KhOHTYSA4CtafhLIF5YC3n5rnuXXYt0z/SE3Pg=; b=zqd3urWVwDkW43ai2aAOvDrM/mxtdQDimLjuFWf+hPCMG3sKbr707KKh4vbWy7YyhI YgS3LJcrOnuOoXhhFvX9yykddjQO7Dk74lT+kd6temYTYg6QxqOR7QJwb7/gQCfEQHTq zSOwNEIYWCsJR235pxgg/mknAwmjObCkHaKjSYheZVZYYDQ+I5jStnV33pYkN7J6ODo/ KA3eSJrb+NC44SsG55v+8YpES69KqUyr9qRfijAkQdEy6wYkZfCMR2e5lbQHc23JIpEW Ex2lHUwdspb0/Hy9r7S2OWfh4m5ncJO5NzGKPk1vxIPyqIFtA3Mv9gr8QJIpW5OIuwth 8HkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="bAI/XGsM"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n13-20020a170902d2cd00b001a814f7db5fsi2946939plc.632.2023.05.18.21.18.10; Thu, 18 May 2023 21:18:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b="bAI/XGsM"; spf=pass (google.com: domain of linux-ext4-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-ext4-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229833AbjESEJg (ORCPT + 99 others); Fri, 19 May 2023 00:09:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43304 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229922AbjESEJf (ORCPT ); Fri, 19 May 2023 00:09:35 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05645170F; Thu, 18 May 2023 21:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xzy+7KhOHTYSA4CtafhLIF5YC3n5rnuXXYt0z/SE3Pg=; b=bAI/XGsMPM6Nx5XdWERnAHXqt7 bL9E5Ls4MDgM7CQztyiTznJoDJZElD7xm6gzy7rLlDnyq43U+6H9FlB3zGUwDDo2Y2lnucwCpX5jW XfQHKTmOMMGEDRUKboc54I1Ul6MvU2DpSJ0XeqQxx51XYFrfHBjAGeyFRBreVbiZs5BGWpwebbHJQ nLNwKxtYde3hAHNLGKRWCf+KAuw1YcxTtxIYCRNNfOrWIzMkKT1joQOopLAT+DNTvp1qtXlFxIHlK cVw8ZvrSyd59Hjd9t9RUU2XhQ8hiVHNj3vY0J3XGJcDiTfkdzKls82lJC1ch6M4zXOf0US/Fi9v4A eXWQmbjA==; Received: from hch by bombadil.infradead.org with local (Exim 4.96 #2 (Red Hat Linux)) id 1pzrQo-00F1Rp-2E; Fri, 19 May 2023 04:09:30 +0000 Date: Thu, 18 May 2023 21:09:30 -0700 From: Christoph Hellwig To: Sarthak Kukreti Cc: dm-devel@redhat.com, linux-block@vger.kernel.org, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Jens Axboe , "Michael S. Tsirkin" , Jason Wang , Stefan Hajnoczi , Alasdair Kergon , Mike Snitzer , Christoph Hellwig , Brian Foster , Theodore Ts'o , Andreas Dilger , Bart Van Assche , "Darrick J. Wong" , stable@vger.kernel.org Subject: Re: [PATCH v7 1/5] block: Don't invalidate pagecache for invalid falloc modes Message-ID: References: <20230518223326.18744-1-sarthakkukreti@chromium.org> <20230518223326.18744-2-sarthakkukreti@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230518223326.18744-2-sarthakkukreti@chromium.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org On Thu, May 18, 2023 at 03:33:22PM -0700, Sarthak Kukreti wrote: > Only call truncate_bdev_range() if the fallocate mode is > supported. This fixes a bug where data in the pagecache > could be invalidated if the fallocate() was called on the > block device with an invalid mode. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: stable@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Looks good: Reviewed-by: Christoph Hellwig